Table filter not working

[cmyip]

When "emit filter events" is checked for table, filter no longer works.

Expected results

Clicking on rows in table should emit filter event and other widgets should react to filter events

Actual results

Browser's console would log "Cannot read property 'columns' of undefined".

Screenshots

How to reproduce the bug

This assumes we are using superset with sample data

1. Open "World's Bank Data" dashboard
2. Select Explore Chart
   
3. Customize and select "Emit filter events"
   
4. Go back to "World's Bank Data", click first column on any rows, you should see Javascript console error

Environment

(please complete the following information):

• superset version: 0.34.1
• python version: 3.7.4
• node.js version: 10.16.3
• npm version: 6.10.3

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• [ y] I have checked the superset logs for python stacktraces and included it here as text if there are any.
• [ y] I have reproduced the issue with at least the latest released version of superset.
• [ y] I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

[issue-label-bot]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.95. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[cmyip]

Same as issue apache-superset/superset-ui-plugins#125

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[oscarostlundgs]

This still seems to be an issue in 1.0.1. The table filter functionality is very useful for interactive dashboards. Any chance we could reopen the issue?

I narrowed down the issue to the dashboardFilter reducer trying to update an undefined filter as the getInitialState function only creates an initial filter for filter_box and filter_select types. (See here)

I believe it may almost work out of the box by allowing for 'table' types in the if statement.

[villebro]

This functionality is currently being actively worked on - please see #12662 for the new functionality that was recently added and is currently being implemented on the table chart (and other charts) to replace the old deprecated logic.

[oost]

OK Thanks. Will that functionality be in the next version of Superset?

If helps, I submitted a PR that fixes the issue with the current implementation. Basically just making sure dashboardFilters get an initial state for tables so when a changeFilter event is emitted, the dashboardFilter state for the chart can be updated.