Fix docker configurations and docker installation guide. #7827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… example using this didn't work because of this (and also as the tooltip says the auto option should be available)
- Fix installation guide regarding passing enviromental variable to docker-compose. - Add gevent installation command in Dockerfile. (Didn't add it in requirements because it's not really a requirement for the whole project) - Add user: root:root to allow superset service to work in development mode. Since access to binded superset directory to local requires root user. - Also add localhost to postgres and redis services to reduce unintended security risk.
- Fix installation guide regarding passing enviromental variable to docker-compose. - Add gevent installation command in Dockerfile. (Didn't add it in requirements because it's not really a requirement for the whole project) - Add user: root:root to allow superset service to work in development mode. Since access to binded superset directory to local requires root user. - Also add localhost to postgres and redis services to reduce unintended security risk.
Codecov Report
@@ Coverage Diff @@
## master #7827 +/- ##
=======================================
Coverage 65.89% 65.89%
=======================================
Files 459 459
Lines 22023 22023
Branches 2418 2418
=======================================
Hits 14512 14512
Misses 7391 7391
Partials 120 120Continue to review full report at Codecov.
|
|
I found out that my PR wasn't rebased with current master so I added rebase after that. I don't know whether it's acceptable or no. If not, please tell me how to fix it. |
pl77
reviewed
Jul 10, 2019
|
These are the diffs I'm using to get it working. I'd appreciate some consideration on how to migrate. These are against the release--0.33 branch. |
|
This is similar to #7744 |
Only part of it. |
|
Any other comment on this PR? |
This was referenced Jul 19, 2019
alex-mark
pushed a commit
to alex-mark/incubator-superset
that referenced
this pull request
Jul 29, 2019
* Add Auto option to point radius to make it work as expected since the example using this didn't work because of this (and also as the tooltip says the auto option should be available) * Remove trailing space * Fix docker configurations and docker installation guide. - Fix installation guide regarding passing enviromental variable to docker-compose. - Add gevent installation command in Dockerfile. (Didn't add it in requirements because it's not really a requirement for the whole project) - Add user: root:root to allow superset service to work in development mode. Since access to binded superset directory to local requires root user. - Also add localhost to postgres and redis services to reduce unintended security risk. * Fix docker configurations and docker installation guide. - Fix installation guide regarding passing enviromental variable to docker-compose. - Add gevent installation command in Dockerfile. (Didn't add it in requirements because it's not really a requirement for the whole project) - Add user: root:root to allow superset service to work in development mode. Since access to binded superset directory to local requires root user. - Also add localhost to postgres and redis services to reduce unintended security risk.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
ADDITIONAL INFORMATION
REVIEWERS