Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing gevent extra dependency in Docker setup #7744

Merged
merged 2 commits into from
Jul 18, 2019

Conversation

bmfs
Copy link
Contributor

@bmfs bmfs commented Jun 20, 2019

CATEGORY

Choose one

  • Bug Fix

SUMMARY

Created a requirements-extra.txt as was suggested in the issue discussion (#7522)

ADDITIONAL INFORMATION

@bmfs bmfs changed the title Fix missing gevent extra dependency in Docker setup Fix missing gevent extra dependency in Docker setup #bug Jun 20, 2019
@bmfs bmfs changed the title Fix missing gevent extra dependency in Docker setup #bug Fix missing gevent extra dependency in Docker setup Jun 20, 2019
@bmfs bmfs force-pushed the bugfix/7522-no-module-gevent branch from 87f4ab9 to f9b7b40 Compare June 20, 2019 19:58
@mistercrunch
Copy link
Member

Hey @bmfs good to see you here. Looks like you need to add the ASF header on the file to pass the license check...

@bmfs bmfs force-pushed the bugfix/7522-no-module-gevent branch from f9b7b40 to 3489fc7 Compare June 21, 2019 07:58
@codecov-io
Copy link

codecov-io commented Jun 21, 2019

Codecov Report

Merging #7744 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7744      +/-   ##
==========================================
- Coverage   65.78%   65.76%   -0.03%     
==========================================
  Files         459      459              
  Lines       21924    21924              
  Branches     2411     2411              
==========================================
- Hits        14423    14418       -5     
- Misses       7380     7385       +5     
  Partials      121      121
Impacted Files Coverage Δ
superset/db_engine_specs/postgres.py 72.72% <0%> (-22.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9abcdcc...206b224. Read the comment docs.

@Aylr
Copy link
Contributor

Aylr commented Jul 11, 2019

This looks great and I'm looking forward to it being merged!

@mistercrunch mistercrunch merged commit fce1166 into apache:master Jul 18, 2019
@aspedrosa
Copy link

#7827 added a command to the Dockerfile installing gevent here.
It should be removed with this new update

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.34.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker-->ModuleNotFoundError: No module named 'gevent'
5 participants