[cypress] fix accessing a cross-origin frame error

[graceguo-supercat]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

Cypress dashboard tests randomly failed with error message:
Error: Blocked a frame with origin "https://*******.com" from accessing a cross-origin frame.

This issues is reported here, and it also gave a solution:
cypress-io/cypress#1951

(There might have other error message, use #7538 track all cypress flaky issues)

TEST PLAN

CI

REVIEWERS

@mistercrunch @michellethomas

[codecov-io]

Codecov Report

Merging #7552 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7552   +/-   ##
=======================================
  Coverage   65.17%   65.17%           
=======================================
  Files         433      433           
  Lines       21428    21428           
  Branches     2360     2360           
=======================================
  Hits        13966    13966           
  Misses       7342     7342           
  Partials      120      120

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae000a...6d4f4ec. Read the comment docs.

[mistercrunch]

Now I'm wondering if chromeWebSecurity would ever catch relevant security issues, and that setting it to false we may miss out on that?

How about only disabling it for the scope of this test? https://docs.cypress.io/guides/references/configuration.html#Cypress-config

[graceguo-supercat]

The cross-origin frame error seems only happens for dashboard test: user save-as a new copy, server-side response a new dashboard id, and then page be redirected to new dashboard.
According to https://docs.cypress.io/guides/guides/web-security.html#Disabling-Web-Security, it is a JavaScript Redirects. In our test, dashboard was not redirect to subdomain or new domain, but cypress still show error randomly.
According to solution suggested by cypress, Set chromeWebSecurity to false in cypress.json and we’ll take care of the rest., i am not sure this config can be changed at run time, but i can still change to see if it will work.

[mistercrunch]

LGTM

[mistercrunch]

Next time we see this test flake again maybe we can set it to false globally

[mistercrunch]

Superseded by #7538

[graceguo-supercat]

@mistercrunch you close this by accident?