Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flaky cypress dashboard test #7538

Closed
wants to merge 1 commit into from

Conversation

mistercrunch
Copy link
Member

This one has been biting us for a while. Let's disable for now.

CATEGORY

Choose one

  • Build / Development Environment

This one has been biting us for a while. Let's disable for now.
@codecov-io
Copy link

Codecov Report

Merging #7538 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #7538   +/-   ##
======================================
  Coverage    65.3%   65.3%           
======================================
  Files         432     432           
  Lines       21388   21388           
  Branches     2355    2355           
======================================
  Hits        13967   13967           
  Misses       7301    7301           
  Partials      120     120

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21a4670...1984c28. Read the comment docs.

@graceguo-supercat
Copy link

graceguo-supercat commented May 17, 2019

what is error when it failed? i will watch this issue and try to fix test.

I saw a error like this (but it shows very inconsistent, really hard to reproduce):
Screen Shot 2019-05-17 at 12 13 40 PM

Do you see similar error like this? I will make a fix for this.

@mistercrunch
Copy link
Member Author

I think I just see a timeout. Yes, let's actually fix the unit test!

@graceguo-supercat
Copy link

@mistercrunch I saw 2 failed build:
https://travis-ci.org/apache/incubator-superset/builds/534229656
https://travis-ci.org/apache/incubator-superset/builds/534083200
And saw these 2 are failed from same error. So I made a PR to fix this error: #7552.
I will still keep watching for any other error message.

@mistercrunch
Copy link
Member Author

Superseded by #7552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants