[Feature] Percentage columns in Table Viz #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mogball It would be nice to add tests with the features to avoid regressions in the future and make coveralls happy :) |
|
@xrmx Yup working on them :U |
Mogball
force-pushed
the
mogball/feature/table_percent_columns
branch
from
59b2689
to
689f142
Compare
Mogball
force-pushed
the
mogball/feature/table_percent_columns
branch
from
689f142
to
ee19169
Compare
|
Coverage increased (+0.2%) to 70.233% when pulling 689f142bd742a7fb317c668e7142a01dd9a410c9 on Mogball:mogball/feature/table_percent_columns into e95132d on apache:master. |
Mogball
force-pushed
the
mogball/feature/table_percent_columns
branch
2 times, most recently
from
fd94c6a
to
e4f6d78
Compare
|
Coverage increased (+0.4%) to 70.767% when pulling 342e61cb36f31ca0be19f3283c54d815e80dc41c on Mogball:mogball/feature/table_percent_columns into d0b5b44 on apache:master. |
|
Coverage increased (+0.3%) to 70.696% when pulling 342e61cb36f31ca0be19f3283c54d815e80dc41c on Mogball:mogball/feature/table_percent_columns into d0b5b44 on apache:master. |
Mogball
force-pushed
the
mogball/feature/table_percent_columns
branch
from
0f642fa
to
edbe1fd
Compare
2 similar comments
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Added percent metric options to table viz * Added unit tests for TableViz * fixed code for python3 * bump travis
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to specify columns for which to display percentages of total.
These are specified in a dropdown control: