-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: document how docker-compose-image-tag requires -dev suffixed images #30144
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ea6e51b
docs: document how docker-compose-image-tag requires -dev suffixed im…
mistercrunch 1493275
tweak
mistercrunch 4d7c165
Update docs/docs/installation/docker-compose.mdx
mistercrunch c2ddd3c
Update docs/docs/installation/docker-compose.mdx
mistercrunch f1117a2
Update docs/docs/installation/docker-compose.mdx
mistercrunch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -38,7 +38,12 @@ Note that there are 3 major ways we support to run `docker compose`: | |||||
1. **docker-compose-image-tag.yml** where we fetch an image from docker-hub say for the | ||||||
`3.0.0` release for instance, and fire it up so you can try it. Here what's in | ||||||
the local branch has no effects on what's running, we just fetch and run | ||||||
pre-built images from docker-hub | ||||||
pre-built images from docker-hub. For `docker compose` to work along with the | ||||||
Postgres image it boots up, you'll want to point to a `-dev`-suffixed TAG, as in | ||||||
`export TAG=4.0.0-dev` or `export TAG=3.0.0-dev`, with `latest-dev` being the default. | ||||||
That's because The `dev` builds happen to package the `psycopg2-binary` required to connect | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
to the Postgres database launched as part of the `docker compose` builds. | ||||||
`` | ||||||
|
||||||
More on these two approaches after setting up the requirements for either. | ||||||
|
||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice touch to get rid of these!