docs: document how docker-compose-image-tag requires -dev suffixed images #30144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages Realized [here](#29999 (comment)) that `docker-compose-image-tag.yml` requires a -dev suffixed image to work as expected. Updating default TAG to latest-dev and related docs. Side mission: removing warning related to version key in docker-compose*.* that are not used/supported anymore
sfirke
approved these changes
Sep 4, 2024
| @@ -30,7 +30,6 @@ x-superset-volumes: | |||
| - ./docker:/app/docker | |||
| - superset_home:/app/superset_home | |||
|
|
|||
| version: "3.7" | |||
| pre-built images from docker-hub. For `docker-compose` to work along with the | ||
| Postgres image it boots up, you'll want to point to a `-dev`-suffixed TAG, as in | ||
| `export TAG=4.0.0-dev` or `export TAG=3.0.0-dev`, `latest-dev` being the default. | ||
| That's because The `dev` builds happen to package the `psycopg2-binary` required to connect |
There was a problem hiding this comment.
Suggested change
| That's because The `dev` builds happen to package the `psycopg2-binary` required to connect | |
| That's because `dev` builds package the `psycopg2-binary` required to connect |
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
michael-s-molina
added
the
v4.1
sadpandajoe
pushed a commit
that referenced
this pull request
Sep 5, 2024
…ages (#30144) Co-authored-by: Sam Firke <[email protected]> (cherry picked from commit 34e240e)
github-actions
bot
added
🍒 4.1.0
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realized here that
docker-compose-image-tag.ymlrequires a -dev suffixed image to work as expected. Updating default TAG to latest-dev and related docs.Side mission: removing warning related to version key in
docker-compose*.*that are not used/supported anymore