chore: remove and deprecate old CSS templates endpoints

[dpgaspar]

SUMMARY

Removing server side rendered pages endpoints from CSS templates view.
Also deprecating csstemplateasyncmodelview/api/read endpoint.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.22%. Comparing base (76d897e) to head (9e56763).
Report is 1094 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/views/css_templates.py	90.90%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #28387       +/-   ##
===========================================
+ Coverage   60.48%   83.22%   +22.73%     
===========================================
  Files        1931      521     -1410     
  Lines       76236    37211    -39025     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    30970    -15144     
+ Misses      28017     6241    -21776     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	49.08% <90.90%> (-0.08%)	⬇️
javascript	?
mysql	77.24% <90.90%> (?)
postgres	77.36% <90.90%> (?)
presto	53.67% <90.90%> (-0.13%)	⬇️
python	83.22% <90.90%> (+19.74%)	⬆️
sqlite	76.82% <90.90%> (?)
unit	58.30% <90.90%> (+0.68%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dpgaspar]

Could we just remove this? not used on the frontend and a REST API exists for this for some time now

[michael-s-molina]

@dpgaspar We discussed this during the release meeting and we agreed to remove these legacy endpoints during a breaking window even if they are not under v1. That's what we did in the past and we just want to be mindful that someone out there might still be using the endpoint.

[rusackas]

@mistercrunch might wanna scope out the CI issue.

[mistercrunch]

mmmh, ran the same command as CI but locally and it worked:

$ supersetbot orglabel --issue 28387 --repo apache/superset
🟢 SUCCESS: added label(s) preset-io to issue 28387

re-triggered CI. Looked like what happens when trying to reference an issue that does not exist yet... Not sure what happened.

[mistercrunch]

This is not a required check, feel free to merge with that check failing while I look into it