Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

90 - Remove old CSS templates views and endpoints #28401

Open
dpgaspar opened this issue May 9, 2024 · 1 comment
Open

90 - Remove old CSS templates views and endpoints #28401

dpgaspar opened this issue May 9, 2024 · 1 comment
Assignees

Comments

@dpgaspar
Copy link
Member

dpgaspar commented May 9, 2024

Remove the already deprecated code: #28387

PR: #31942

@dpgaspar dpgaspar converted this from a draft issue May 9, 2024
@dpgaspar dpgaspar self-assigned this May 9, 2024
Copy link

dosubot bot commented May 9, 2024

To remove old CSS templates, views, and endpoints as outlined in the provided code, follow these steps:

  1. Identify Dependencies: Check both frontend and backend code for references to the CSS templates, views, or endpoints you plan to remove. This includes reviewing components and API endpoints that interact with CSS templates.

  2. Update or Remove References: If any functionalities or components depend on the elements you're removing, update them to use alternatives or remove those functionalities if they're no longer needed.

  3. Use the Bulk Delete Endpoint: For bulk deletion, use the endpoint /api/v1/css_template/?q= with a query parameter that specifies the IDs of the templates to be deleted. Ensure proper error handling and response messages during the deletion process.

  4. Test After Removal: Thoroughly test your application to ensure no other functionalities are affected by the removal. This includes testing list view, creation, editing, and deletion functionalities related to CSS templates.

  5. Commit Changes with Documentation: Once confirmed that the removal does not adversely affect other functionalities, commit your changes with clear documentation on what was removed and why.

By carefully following these steps, you can ensure a smooth removal process without negatively impacting your project's functionality.

Details

Sources


About Dosu
This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

To continue the conversation, mention @dosu.

@michael-s-molina michael-s-molina moved this from Proposals - Not proposed for consensus to To Propose in Apache Superset 5.0 Dec 11, 2024
@michael-s-molina michael-s-molina changed the title Remove old CSS templates views and endpoints 90 - Remove old CSS templates views and endpoints Dec 16, 2024
@michael-s-molina michael-s-molina moved this from Propose for Lazy Consensus to Lazy Consensus Reached in Apache Superset 5.0 Dec 20, 2024
@michael-s-molina michael-s-molina moved this from Lazy Consensus Reached to Work in Progress in Apache Superset 5.0 Jan 17, 2025
@michael-s-molina michael-s-molina moved this from Work in Progress to Completed in Apache Superset 5.0 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

No branches or pull requests

2 participants