feat: improve event logging for queries + refactor #27943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
log_queries
branch
from
4e2952e to
0a8cfe4
Compare
mistercrunch
force-pushed
the
log_queries
branch
from
0a8cfe4 to
d524183
Compare
mistercrunch
commented
Apr 9, 2024
mistercrunch
commented
Apr 9, 2024
mistercrunch
commented
Apr 9, 2024
mistercrunch
commented
Apr 9, 2024
mistercrunch
force-pushed
the
log_queries
branch
from
dbc8783 to
0b7e976
Compare
The driver for this PR was to enrich event logging around database engine and database drivers for events that interact directly with analytics databases. Digging a bit into the logging code: - I realized that `request.form` is empty when pushing JSON payload, and `request.json` should be used. This should automatically capture more automated logging that parses context out of the request object proactively - Adding an event `execute_sql` that targets just that, that **isn't** called when hitting the cache for instance. Using the context manager insures capturing the duration of the call as well. - a bit of refactor here and there
mistercrunch
force-pushed
the
log_queries
branch
from
0b7e976 to
2943680
Compare
john-bodley
reviewed
Apr 16, 2024
john-bodley
added
risk:breaking-change
mistercrunch
commented
Apr 16, 2024
mistercrunch
removed
risk:breaking-change
betodealmeida
approved these changes
Apr 22, 2024
Co-authored-by: Beto Dealmeida <[email protected]>
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
Co-authored-by: Beto Dealmeida <[email protected]>
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
Co-authored-by: Beto Dealmeida <[email protected]>
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Co-authored-by: Beto Dealmeida <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The main driver for this PR was to enrich event logging around database engine and database drivers for events that interact directly with analytics databases. While touching this up, I did some refactor along the way.
execute_sqlthat targets just that, that isn't called when hitting the cache for instance. Using the context manager insures capturing the duration of the call as well.SQL_QUERY_MUTATORandMUTATE_AFTER_SPLIT, where code had been copy/pasted and reimplemented in various places. Here I move it as a method of the Database model.request.formis empty when posting JSON payload, andrequest.jsonshould be used instead. This should automatically capture more automated logging that parses context out of the request object proactivelypost_process_dfas it seemed logical to isolate this out ofget_df