Skip to content

Commit

Permalink
fix sql_lab_test.py
Browse files Browse the repository at this point in the history
  • Loading branch information
mistercrunch committed Apr 9, 2024
1 parent d524183 commit dbc8783
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions tests/unit_tests/sql_lab_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def test_execute_sql_statement(mocker: MockerFixture, app: None) -> None:
database = query.database
database.allow_dml = False
database.apply_limit_to_sql.return_value = "SELECT 42 AS answer LIMIT 2"
database.mutate_sql_based_on_config.return_value = "SELECT 42 AS answer LIMIT 2"
db_engine_spec = database.db_engine_spec
db_engine_spec.is_select_query.return_value = True
db_engine_spec.fetch_data.return_value = [(42,)]
Expand Down Expand Up @@ -71,15 +72,16 @@ def test_execute_sql_statement_with_rls(
from superset.sql_lab import execute_sql_statement

sql_statement = "SELECT * FROM sales"
sql_statement_with_rls = f"{sql_statement} WHERE organization_id=42"
sql_statement_with_rls_and_limit = f"{sql_statement_with_rls} LIMIT 101"

query = mocker.MagicMock()
query.limit = 100
query.select_as_cta_used = False
database = query.database
database.allow_dml = False
database.apply_limit_to_sql.return_value = (
"SELECT * FROM sales WHERE organization_id=42 LIMIT 101"
)
database.apply_limit_to_sql.return_value = sql_statement_with_rls_and_limit
database.mutate_sql_based_on_config.return_value = sql_statement_with_rls_and_limit
db_engine_spec = database.db_engine_spec
db_engine_spec.is_select_query.return_value = True
db_engine_spec.fetch_data.return_value = [(42,)]
Expand Down

0 comments on commit dbc8783

Please sign in to comment.