fix: annotation broken

[zhaoyongjie]

SUMMARY

Currently, the annotation on the time series chart has been broken.

1. This error is from the TypeScript type guard function.
2. The annotation on the master branch doesn't apply annotation_data from the query response.

After these fixes it turns out that the Apply button is not working again, which I think should be fixed in a seprated PR. Also, the annnotation layer logic is very difficult to maintain, I would suggest investing more time in rewriting the current codes.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

annotation.mov

Before

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #20651 (df054bd) into master (c29261b) will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##           master   #20651   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1753     1753           
  Lines       65823    65827    +4     
  Branches     7007     7006    -1     
=======================================
+ Hits        44005    44010    +5     
+ Misses      20032    20031    -1     
  Partials     1786     1786           

Flag	Coverage Δ
javascript	51.95% <85.71%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...art-controls/src/sections/annotationsAndLayers.tsx	100.00% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts	0.00% <0.00%> (ø)
...uperset-ui-core/src/query/types/AnnotationLayer.ts	100.00% <100.00%> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts	55.95% <100.00%> (+1.19%)	⬆️
...ugins/plugin-chart-echarts/src/utils/annotation.ts	85.10% <100.00%> (+1.38%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c29261b...df054bd. Read the comment docs.

[john-bodley]

Thanks @zhaoyongjie for the fix and adding unit tests. For context I'm running into the exact same issue whilst testing a prior Preset release internally at Airbnb.

I was wondering whether you knew what PR introduced said regression and/or whether it was possible to simply revert it?

[zhaoyongjie]

Thanks @zhaoyongjie for the fix and adding unit tests. For context I'm running into the exact same issue whilst testing a prior Preset release internally at Airbnb.

I was wondering whether you knew what PR introduced said regression and/or whether it was possible to simply revert it?

thanks for the review, this issue from the PR

[ktmud]

LGTM

[rusackas]

@zhaoyongjie any idea why codecov is failing on this PR? There seem to be similarly confusing codecov failures on lots of PRs right now, but I'm not sure yet what to make of it.

[zhaoyongjie]

@rusackas the coverage issue didn't bring from this PR, the master branch has broken some days. I will look into / fix coverage issue in the separated pr.

[slavanorm]

can we say that this issue is not complete?
in 2.* version annotations are broken:
#24374