-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line chart. Event annotation not work #24374
Comments
We have had the same error on 2.1.0 when adding interval annotations too:
To fix, I had to add a column to the dataset called It shouldn't need that though, so this is very likely to be a bug. |
idk.. i created p1d and P1D cols and it still not working |
Same here but with 'P1M' column. Event Annotation on Mixed Chart. |
This issue seems to happen when adding annotations to a chart when:
A work around that worked for me is to recreate the chart with the annotation and then add it to the dashboard. |
Thanks for the comment. Gave me an idea that actually works: Checking "Override Time Grain" does the job for me, even if the chart already is part of a dashboard! |
Same issue here 🤚 |
Same issue. What solved it for me, was to recreate the annotations table outside of any dashboard and set time grain in the annotation table to "minute". For the line chart I use time grain "hour" or "minute". |
Seems we have a couple workarounds, and I'm wondering if this is enough to close the issue. Since it's been silent for upward of 6 months, it's at risk of being closed as stale. Note that soon we'll also only support Superset 4.0 and up, once 4.1 is out. If people can make sure this is still an issue (it probably is) in 4.0, that'd be appreciated. |
Using 4.0.2, I heard today from a user who has a problem with annotation layers sometimes adding, sometimes not, to the same chart. I was able to replicate it though I don't understand when it fails and when it succeeds. We don't get any error message at all, maybe that's because we're using a saved Superset annotation source instead of a table? We just can't click "apply" or "OK" on the modal. Seems related to this issue, maybe has the same underlying problem. Just now I was unable to add it to a chart. I refreshed my browser and then I could add it 😕 No error message, nothing in the application logs. |
Line chart. Event annotation not work.
error raised from python (raises every time):
How to reproduce the bug
Screenshots
Environment
2.1.0
3.10
Checklist
Additional context
SQL server: psql 14
failed annotation with "superset annotation" and "table", same error.
works on 1.5.3, so feels like recent changes are breaking
The text was updated successfully, but these errors were encountered: