Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VERSIONED_EXPORTS): Ensure dashboards and charts adhere to the VERSIONED_EXPORTS feature flag #20368

Conversation

john-bodley
Copy link
Member

@john-bodley john-bodley commented Jun 13, 2022

SUMMARY

It seems like charts, databases etc. adhere to the VERSIONED_EXPORTS feature flag with regards to whether one can export said entity however dashboards and datasets don't. This PR remedies the issue.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

When VERSIONED_EXPORT is set to False

Before

Screen Shot 2022-06-13 at 4 56 02 PM

Screen Shot 2022-06-13 at 4 55 50 PM

After

Screen Shot 2022-06-13 at 4 49 21 PM

Screen Shot 2022-06-13 at 4 49 04 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley requested a review from ktmud June 13, 2022 22:37
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #20368 (a8e8bb7) into master (e1532f6) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head a8e8bb7 differs from pull request most recent head dd80f95. Consider uploading reports for the commit dd80f95 to get more accurate results

@@            Coverage Diff             @@
##           master   #20368      +/-   ##
==========================================
- Coverage   66.67%   66.67%   -0.01%     
==========================================
  Files        1738     1738              
  Lines       65078    65078              
  Branches     6885     6887       +2     
==========================================
- Hits        43391    43389       -2     
  Misses      19939    19939              
- Partials     1748     1750       +2     
Flag Coverage Δ
javascript 51.67% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 57.14% <0.00%> (-0.96%) ⬇️
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 54.60% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1532f6...dd80f95. Read the comment docs.

@john-bodley john-bodley requested review from hughhhh and AAfghahi June 13, 2022 23:57
@john-bodley john-bodley merged commit c3fdd52 into apache:master Jun 14, 2022
@imanollew
Copy link

Hello, Im not sure if Im misunderstanding something but my VERSIONED_EXPORT flag is set to TRUE, yet I cant export any dashboard / dataset / chart because the button "export" is hidden, just like in the last 2 pictures. (Im on version 1.5.1)

Is there any fix for this?

@vergenzt
Copy link

vergenzt commented Jan 8, 2024

@imanollew I think your issue is being tracked at #26417

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants