Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot import/export Charts, Databases, Datasets, and Dashboards with VERSIONED_EXPORT=False #26417

Closed
3 tasks done
CollinEMac opened this issue Jan 5, 2024 · 8 comments
Closed
3 tasks done

Comments

@CollinEMac
Copy link

CollinEMac commented Jan 5, 2024

Due to this change, imports/exports are hidden from the user when VERSIONED_EXPORT is set to False. My team requires the ability to allow users to do a non-versioned export and import.

There have been a few questions about this issue before but it doesn't look like there is currently an open issue:

  1. fix(VERSIONED_EXPORTS): Ensure dashboards and charts adhere to the VERSIONED_EXPORTS feature flag #20368 (comment)
  2. /dashboard/export API compatibility issue between v1.5 and v2.0 #21001 (comment)

How to reproduce the bug

  1. Set VERSIONED_EXPORT to False in your config. (it's True by default)
  2. Go to import or export a Charts, Databases, Datasets, or Dashboards.
  3. The import/export button isn't where it normally would be.

Expected results

I'd expect to be able to import and export as a JSON file when VERSIONED_EXPORT is turned off.

Actual results

The import/export button doesn't display.

Screenshots

What I'd expect to see (export)

Screenshot 2024-01-05 at 4 09 13 PM

What I actually see (export)

Screenshot 2024-01-05 at 4 09 20 PM

What I'd expect to see (import)
Screenshot 2024-01-05 at 4 08 47 PM
What I actually see (import)
Screenshot 2024-01-05 at 4 08 55 PM

Environment

  • browser type and version: Any
  • superset version: 2.1.0 (Issue is present in latest - 3.1.0 as well)
  • python version: 3.8 (Issue doesn't depend on python version though)
  • node.js version: 20 (Issue doesn't depend on node version though)
  • any feature flags active: VERSIONED_EXPORT

Checklist

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Worth noting that prior to Superset version 2.0, exporting and importing was available when versioned or non-versioned.

@michael-s-molina
Copy link
Member

Hi @CollinEMac. When VERSIONED_EXPORT is set to False, you can import dashboards using the legacy feature which is available in the Settings menu.

Screenshot 2024-01-08 at 08 19 31

@vergenzt
Copy link

vergenzt commented Jan 8, 2024

@michael-s-molina how do you export dashboards using the legacy feature? That's an important part of the functionality we're missing.

I think this issue may have been closed premature/mistakenly.

@CollinEMac CollinEMac changed the title Only able to import/export Charts, Databases, Datasets, and Dashboards via Versioned Export Cannot import/export Charts, Databases, Datasets, and Dashboards with VERSIONED_EXPORT=False Jan 8, 2024
@michael-s-molina
Copy link
Member

@michael-s-molina how do you export dashboards using the legacy feature? That's an important part of the functionality we're missing.

I'm not sure if it's possible. Let me ping some folks with more context about this feature @eschutho @betodealmeida @hughhhh

@eschutho
Copy link
Member

eschutho commented Jan 9, 2024

HI @CollinEMac and @vergenzt can I ask what the bugs are that you're finding with the new import/export feature? Since we're actively supporting that version, it will be easier for us to address any issues with that feature moving forward rather than supporting the old version. I saw that one of the bug tickets mentioned missing an export button with the flag turned on. You'll want to also give permissions for can_export to see the export button. Is that the main issue?

@CollinEMac
Copy link
Author

Hi @eschutho,

Yes, our primary concern is that the export button is hidden for dashboards. We've verified that can_export is True. However, it's required that the VERSIONED_EXPORT feature flag is also set to True (link to related code below). I'm not sure why versioned export would be required to export a dashboard. This feels like unexpected behavior to me.

https://github.com/apache/superset/blob/2.1.0/superset-frontend/src/views/CRUD/dashboard/DashboardList.tsx#L166

@eschutho
Copy link
Member

If you set VERSIONED_EXPORT to true, do you see the export button?

@CollinEMac
Copy link
Author

Yes, we can see the export button with VERSIONED_EXPORT turned on.

@michael-s-molina
Copy link
Member

michael-s-molina commented Jan 26, 2024

Closing this issue assuming that the export button is visible with VERSIONED_EXPORT turned on and that

Since we're actively supporting that version, it will be easier for us to address any issues with that feature moving forward rather than supporting the old version.

Please feel free to reopen it if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants