Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/dashboard/export API compatibility issue between v1.5 and v2.0 #21001

Closed
3 tasks done
xingyc15 opened this issue Aug 6, 2022 · 4 comments
Closed
3 tasks done

/dashboard/export API compatibility issue between v1.5 and v2.0 #21001

xingyc15 opened this issue Aug 6, 2022 · 4 comments
Labels
#bug Bug report

Comments

@xingyc15
Copy link
Contributor

xingyc15 commented Aug 6, 2022

We have some dashboard developed in v1.5.0. After we upgrade the dashboard into v2.0.0, and use the /dashboard/export API endpoint to export the dashboards, there are unreadable characters in the exported json file.

How to reproduce the bug

  1. Develop a dashboard under superset version 1.5.0
  2. Upgrade superset to version 2.0.0
  3. Use /dashboard/export API to export the dashboard into a json file
  4. See error

Expected results

The dashboard json exported from v1.5.0 should be able to be successfully parsed by superset v2.0.0

Actual results

There are some unreadable characters.

The json file starts with this:
PK!�gٝMM.dashboard_export_20220806T005733/metadata.yamlversion: 1.0.0 type: Dashboard timestamp: '2022-08-06T00:57:33.133934+00:00' PK!?�8���Fdashboard_export_20220806T005733/datasets/pinot/map_labeling_logs.yamltable_name: map_labeling_logs ...

Environment

  • superset version: 1.5.0 and 2.0.0

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@xingyc15 xingyc15 added the #bug Bug report label Aug 6, 2022
@grumpy-miner
Copy link
Contributor

It is because in v2.0.0 dashboard is downloaded as zip file.
If you want to continue exporting dashboard as json file you need to add VERSIONED_EXPORT as False in FEATURE_FLAGS

FEATURE_FLAGS = {
        ...
        "VERSIONED_EXPORT": False,
    }

@Agos88
Copy link

Agos88 commented Apr 26, 2023

Any update about this bug?
If we use FEATURE_FLAGS = { ... "VERSIONED_EXPORT": False, } this condition will be always false
const canExport = hasPerm('can_export') && isFeatureEnabled(FeatureFlag.VERSIONED_EXPORT);

@vergenzt
Copy link

vergenzt commented Jan 8, 2024

@Agos88 I think what you're talking about is a separate issue, and has been reported/is being tracked at #26417

@rusackas
Copy link
Member

I'm assuming that since this has been quiet for so long, we're all good now? VERSIONED_EXPORT has been deprecated, and we no longer support versions prior to 3.1/4.0. If this needs more discussion, we can certainly revisit/reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

No branches or pull requests

5 participants