chore: convert URLShortLinkButton to typescript

[ktmud]

SUMMARY

Convert URLShortLinkButton to TypeScript (tsx) in preparation for bigger refactor where we support including activeTabs in dashboard urls (currently you can only highlight one tab using location.hash).

No visible changes in the UI.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #19954 (2e2053f) into master (2e2053f) will not change coverage.
The diff coverage is n/a.

❗ Current head 2e2053f differs from pull request most recent head 3304e31. Consider uploading reports for the commit 3304e31 to get more accurate results

@@           Coverage Diff           @@
##           master   #19954   +/-   ##
=======================================
  Coverage   66.28%   66.28%           
=======================================
  Files        1712     1712           
  Lines       63964    63964           
  Branches     6726     6726           
=======================================
  Hits        42396    42396           
  Misses      19856    19856           
  Partials     1712     1712           

Flag	Coverage Δ
hive	53.65% <0.00%> (ø)
javascript	51.25% <0.00%> (ø)
mysql	81.99% <0.00%> (ø)
postgres	82.04% <0.00%> (ø)
presto	53.51% <0.00%> (ø)
python	82.47% <0.00%> (ø)
sqlite	81.78% <0.00%> (ø)
unit	48.63% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e2053f...3304e31. Read the comment docs.

[villebro]

Looks much nicer now, thanks for cleaning this up! 👍 Minor improvement suggestion, other than that LGTM.

[villebro]

This got me wondering, can we really have this component without dashboardId being populated: And based on a quick search, this appears to be the only component that's using this, and there dashboardId is always set:

superset/superset-frontend/src/components/AnchorLink/index.jsx

Line 28 in 902ac05

dashboardId: PropTypes.number,

So I think we can clean this up further by making dashboardId mandatory in URLShortLinkButtonProps.

[ktmud]

@villebro I made more changes to this PR:

• Converted AnchorLink component to tsx, too
• Moved both AnchorLink and URLShortLinkButton to src/dashboards since they really are dashboard only components.
• Renamed AnchorLinkProps["anchorLinkId"] to AnchorLinkProps["id"]
• Changed showShortLinkButton to be default and made dashboardId mandatory

[ktmud]

Adding dashboardId fixes the bug where the copy button doesn't copy the right URL for section headers in dashboards.

[ktmud]

Merging to unblock followup PRs