forked from apache/superset
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: convert URLShortLinkButton to typescript (apache#19954)
- Loading branch information
1 parent
722e0f2
commit edfebb5
Showing
11 changed files
with
272 additions
and
322 deletions.
There are no files selected for viewing
73 changes: 0 additions & 73 deletions
73
superset-frontend/src/components/AnchorLink/AnchorLink.test.jsx
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
120 changes: 0 additions & 120 deletions
120
superset-frontend/src/components/URLShortLinkButton/index.jsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
superset-frontend/src/dashboard/components/AnchorLink/AnchorLink.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
/** | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
import React from 'react'; | ||
import { render, act } from 'spec/helpers/testing-library'; | ||
import AnchorLink from 'src/dashboard/components/AnchorLink'; | ||
|
||
describe('AnchorLink', () => { | ||
const props = { | ||
id: 'CHART-123', | ||
dashboardId: 10, | ||
}; | ||
|
||
const globalLocation = window.location; | ||
afterEach(() => { | ||
window.location = globalLocation; | ||
}); | ||
|
||
it('should scroll the AnchorLink into view upon mount if id matches hash', async () => { | ||
const callback = jest.fn(); | ||
jest.spyOn(document, 'getElementById').mockReturnValue({ | ||
scrollIntoView: callback, | ||
} as unknown as HTMLElement); | ||
|
||
window.location.hash = props.id; | ||
await act(async () => { | ||
render(<AnchorLink {...props} />, { useRedux: true }); | ||
}); | ||
expect(callback).toHaveBeenCalledTimes(1); | ||
|
||
window.location.hash = 'random'; | ||
await act(async () => { | ||
render(<AnchorLink {...props} />, { useRedux: true }); | ||
}); | ||
expect(callback).toHaveBeenCalledTimes(1); | ||
}); | ||
|
||
it('should render anchor link without short link button', () => { | ||
const { container, queryByRole } = render( | ||
<AnchorLink showShortLinkButton={false} {...props} />, | ||
{ useRedux: true }, | ||
); | ||
expect(container.querySelector(`#${props.id}`)).toBeInTheDocument(); | ||
expect(queryByRole('button')).toBe(null); | ||
}); | ||
|
||
it('should render short link button', () => { | ||
const { getByRole } = render( | ||
<AnchorLink {...props} showShortLinkButton />, | ||
{ useRedux: true }, | ||
); | ||
expect(getByRole('button')).toBeInTheDocument(); | ||
}); | ||
}); |
Oops, something went wrong.