Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(histogram): display correct percentile value instead of formula #18084

Merged
merged 2 commits into from
Feb 9, 2022
Merged

fix(histogram): display correct percentile value instead of formula #18084

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6bae39
fix histogram percentile value not displaying correctly
Jan 19, 2022
ab067bd
reenable prettier, reformated Histogram.jsx
Feb 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions superset-frontend/.prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,4 @@ CHANGELOG.md
*-topo.json
temporary_superset_ui/
storybook-static/
plugins/legacy-plugins-chart-histogram/src/Histogram.jsx
Copy link
Member

@nytai nytai Feb 9, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this necessary? Can you just run prettier or fix the error instead of ignoring this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I first ran Prettier on the file, it didn't change anything. I suspect it was because either I misconfigured Prettier on my local machine, or Prettier confused and couldn't reformat. I will try to configure it again.

2 changes: 1 addition & 1 deletion superset-frontend/plugins/legacy-plugin-chart-histogram/src/Histogram.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class CustomHistogram extends React.PureComponent {
</div>
<div>
<strong>{t('percentile (exclusive)')} </strong>
{`{((datum.cumulativeDensity - datum.density) * 100).toPrecision(4)}th`}
{`${((datum.cumulativeDensity - datum.density) * 100).toPrecision(4)}th`}
</div>
</div>
)}
Expand Down