-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(histogram): display correct percentile value instead of formula #18084
fix(histogram): display correct percentile value instead of formula #18084
Conversation
superset-frontend/.prettierignore
Outdated
@@ -26,3 +26,4 @@ CHANGELOG.md | |||
*-topo.json | |||
temporary_superset_ui/ | |||
storybook-static/ | |||
plugins/legacy-plugins-chart-histogram/src/Histogram.jsx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this necessary? Can you just run prettier or fix the error instead of ignoring this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I first ran Prettier on the file, it didn't change anything. I suspect it was because either I misconfigured Prettier on my local machine, or Prettier confused and couldn't reformat. I will try to configure it again.
Codecov Report
@@ Coverage Diff @@
## master #18084 +/- ##
==========================================
- Coverage 66.36% 66.31% -0.05%
==========================================
Files 1570 1595 +25
Lines 61740 62596 +856
Branches 6241 6297 +56
==========================================
+ Hits 40972 41510 +538
- Misses 19170 19440 +270
- Partials 1598 1646 +48
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SUMMARY
This PR addresses issue #17550 regarding histogram percentile displaying the formula instead of the value. The long formula also causes the entire tooltip box to be long, which possibly leads to the entire tooltip being hidden to the side of the plot.
BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
superset-frontend/plugins/legacy-plugin-chart-histogram/src/Histogram.jsx
to prevent ERROR related to line length duringnpm build
.