Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

other: Provide option to add environment variables to only supersetNode #16627

Merged
merged 6 commits into from
Sep 17, 2021
Merged

other: Provide option to add environment variables to only supersetNode #16627

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
97c17a8
Add env variables for supersetNode in Helm template
dd-willgan Sep 7, 2021
2818781
Typo in template
dd-willgan Sep 7, 2021
af83568
Removed unnecessary if
dd-willgan Sep 17, 2021
74e2c22
Revert "Removed unnecessary if"
dd-willgan Sep 17, 2021
7aa8a39
Bumping chart version to 0.3.8
dd-willgan Sep 17, 2021
f0b0a54
Merge branch 'master' into supersetnode-env
craig-rueda Sep 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions helm/superset/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@ spec:
value: {{ $value | quote }}
{{- end }}
{{- end }}
{{- if .Values.supersetNode.env }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this if necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpgaspar No but after thinking about it I would prefer to keep it to match how extraEnv is read in this file and others.

{{- range $key, $value := .Values.supersetNode.env }}
- name: {{ $key | quote}}
value: {{ $value | quote }}
{{- end }}
{{- end }}
envFrom:
- secretRef:
name: {{ tpl .Values.envFromSecret . | quote }}
Expand Down
1 change: 1 addition & 0 deletions helm/superset/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ supersetNode:
db_user: superset
db_pass: superset
db_name: superset
env: {}
forceReload: false # If true, forces deployment to reload on each upgrade
initContainers:
- name: wait-for-postgres
Expand Down