other: Provide option to add environment variables to only supersetNode #16627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dd-willgan
changed the title
dd-willgan
changed the title
dpgaspar
approved these changes
Sep 17, 2021
| @@ -79,6 +79,12 @@ spec: | |||
| value: {{ $value | quote }} | |||
| {{- end }} | |||
| {{- end }} | |||
| {{- if .Values.supersetNode.env }} | |||
There was a problem hiding this comment.
@dpgaspar No but after thinking about it I would prefer to keep it to match how extraEnv is read in this file and others.
craig-rueda
approved these changes
Sep 17, 2021
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…de (apache#16627) * Add env variables for supersetNode in Helm template * Typo in template * Removed unnecessary if * Revert "Removed unnecessary if" This reverts commit af83568. * Bumping chart version to 0.3.8 Co-authored-by: Craig Rueda <[email protected]>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
…de (apache#16627) * Add env variables for supersetNode in Helm template * Typo in template * Removed unnecessary if * Revert "Removed unnecessary if" This reverts commit af83568. * Bumping chart version to 0.3.8 Co-authored-by: Craig Rueda <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I'm adding an option to only add env variables to the main supersetNode pod through the Helm chart. See #16625.
TESTING INSTRUCTIONS
I added some test values in
values.yamland confirmed that they were being read properly locally.ADDITIONAL INFORMATION