Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add resample operator in post processing #16607

Merged
merged 5 commits into from
Sep 17, 2021
Merged

feat: add resample operator in post processing #16607

merged 5 commits into from
Sep 17, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Sep 6, 2021 •
edited
Loading

SUMMARY

introduce resample operator in post processing
frontend codes at: apache-superset/superset-ui#1349

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

image

TESTING INSTRUCTIONS

  1. Select Time-series Line Chart
  2. Select birth_names dataset
  3. time grain set to Year; Time rang set to 2000 - 2005
  4. Resample rule set to 1D
  5. Resample method set to ffill
  6. Run query

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 6, 2021 •
edited
Loading

Codecov Report

Merging #16607 (fd365c2) into master (420dd5b) will increase coverage by 0.16%.
The diff coverage is 71.51%.

❗ Current head fd365c2 differs from pull request most recent head d89de62. Consider uploading reports for the commit d89de62 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16607      +/-   ##
==========================================
+ Coverage   76.69%   76.86%   +0.16%     
==========================================
  Files        1003     1007       +4     
  Lines       53959    54174     +215     
  Branches     7330     7463     +133     
==========================================
+ Hits        41386    41639     +253     
+ Misses      12334    12295      -39     
- Partials      239      240       +1
Flag Coverage Δ
hive ?
mysql 81.73% <69.22%> (+0.15%) ⬆️
postgres 81.79% <69.37%> (+0.23%) ⬆️
presto 81.69% <69.62%> (?)
python 82.06% <69.62%> (+0.09%) ⬆️
sqlite 81.41% <69.22%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Menu/Menu.tsx 69.79% <ø> (ø)
...rontend/src/components/Select/DeprecatedSelect.tsx 82.35% <0.00%> (-3.37%) ⬇️
superset-frontend/src/dashboard/actions/hydrate.js 1.69% <0.00%> (-0.03%) ⬇️
...et-frontend/src/dashboard/components/Dashboard.jsx 78.84% <ø> (ø)
...src/dashboard/components/gridComponents/Column.jsx 87.87% <ø> (ø)
...nd/src/dashboard/components/gridComponents/Row.jsx 86.66% <ø> (ø)
...mponents/nativeFilters/FiltersConfigModal/utils.ts 72.22% <ø> (-1.39%) ⬇️
...nd/src/dashboard/components/nativeFilters/utils.ts 56.25% <ø> (ø)
...perset-frontend/src/dashboard/util/isValidChild.ts 85.71% <ø> (-0.96%) ⬇️
...ntend/src/explore/components/ExploreChartPanel.jsx 14.28% <0.00%> (-0.72%) ⬇️
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 420dd5b...d89de62. Read the comment docs.

@zhaoyongjie zhaoyongjie mentioned this pull request Sep 6, 2021
Merged
@zhaoyongjie zhaoyongjie requested a review from villebro September 6, 2021 10:28
@zhaoyongjie zhaoyongjie requested a review from villebro September 7, 2021 03:04
villebro
villebro reviewed Sep 17, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments

superset/utils/pandas_postprocessing.py Outdated Show resolved Hide resolved
superset/utils/pandas_postprocessing.py Outdated Show resolved Hide resolved
villebro
villebro approved these changes Sep 17, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie merged commit cc1c6c1 into apache:master Sep 17, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@zhaoyongjie
feat: add resample operator in post processing (apache#16607)
37d706e 
* feat: add resample operator in post processing

* wip

* fill zero values

* updates

* fix ut
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@zhaoyongjie
feat: add resample operator in post processing (apache#16607)
5544156 
* feat: add resample operator in post processing

* wip

* fill zero values

* updates

* fix ut
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhaoyongjie @villebro @mistercrunch