chore: Pylint downgrade (#16617)

* Update testing.in * chore: downgrade pylint to 2.9.6 * downgrade dependence for pylint * trim space * pylint rules Co-authored-by: Yongjie Zhao <[email protected]>
apache · Sep 8, 2021 · 420dd5b · 420dd5b
1 parent 519baa6
commit 420dd5b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/requirements/testing.in b/requirements/testing.in
@@ -28,7 +28,7 @@ openpyxl
 parameterized
 pyfakefs
 pyhive[presto]>=0.6.3
-pylint==2.10.2
+pylint==2.9.6
 pytest
 pytest-cov
 statsd

diff --git a/requirements/testing.txt b/requirements/testing.txt
@@ -1,4 +1,4 @@
-# SHA1:59e47200215ca4695f09e03a773e1a6f310f78da
+# SHA1:97a1d3094738243d47824948a0d6fdcb4a784524
 #
 # This file is autogenerated by pip-compile-multi
 # To update, run:
@@ -11,7 +11,7 @@
     # via -r requirements/base.in
 appnope==0.1.2
     # via ipython
-astroid==2.7.2
+astroid==2.6.6
     # via pylint
 backcall==0.2.0
     # via ipython
@@ -71,7 +71,7 @@ pyhive[hive,presto]==0.6.4
     # via
     #   -r requirements/development.in
     #   -r requirements/testing.in
-pylint==2.10.2
+pylint==2.9.6
     # via -r requirements/testing.in
 pytest==6.2.4
     # via

diff --git a/superset/tasks/async_queries.py b/superset/tasks/async_queries.py
@@ -73,6 +73,7 @@ def load_chart_data_into_cache(
         raise exc
     except Exception as exc:
         # TODO: QueryContext should support SIP-40 style errors
+        # pylint: disable=no-member
         error = exc.message if hasattr(exc, "message") else str(exc)  # type: ignore
         errors = [{"message": error}]
         async_query_manager.update_job(
@@ -127,7 +128,9 @@ def load_explore_json_into_cache(  # pylint: disable=too-many-locals
         logger.warning("A timeout occurred while loading explore json, error: %s", ex)
         raise ex
     except Exception as exc:
+        # pylint: disable=no-member
         if isinstance(exc, SupersetVizException):
+            # pylint: disable=no-member
             errors = exc.errors
         else:
             error = exc.message if hasattr(exc, "message") else str(exc)  # type: ignore

diff --git a/superset/views/core.py b/superset/views/core.py
@@ -2566,7 +2566,7 @@ def is_query_handled(cls, query: Optional[Query]) -> bool:
             QueryStatus.TIMED_OUT,
         ]
 
-    def sql_json_exec(  # pylint: disable=too-many-statements
+    def sql_json_exec(  # pylint: disable=too-many-statements,useless-suppression
         self,
         execution_context: SqlJsonExecutionContext,
         log_params: Optional[Dict[str, Any]] = None,