-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Make View Query Modal draggable and resizable in Dashboard #16447
chore: Make View Query Modal draggable and resizable in Dashboard #16447
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16447 +/- ##
=======================================
Coverage 76.41% 76.41%
=======================================
Files 1002 1002
Lines 53635 53635
Branches 6851 6851
=======================================
Hits 40985 40985
Misses 12411 12411
Partials 239 239
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@geido Ephemeral environment spinning up at http://34.221.177.62:8080. Credentials are |
LGTM! thanks for the UX upgrade :) It will be great if the page remains scrollable when the modal is open. we can make incremental improvement as users request. |
That's a very nice suggestion @junlincc. I will attempt this change in a separate PR asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
test cases added |
SUMMARY
It enables
resizable
anddraggable
properties for the "View query" Modal in Dashboard.BEFORE
AFTER
a.new.dashboard.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION