-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Viewquery]Allow View Query Screen to move around #16205
Comments
great idea! I can see how users can benefit from both of your suggestion. This may not be prioritized anytime soon from the development team, however, if you would like to contribute to the project, we are more than happy to help get it through. :) 🙏 |
Sorry, I'm not a coder, at least not in python, etc. I'm a data warehouse guy so I'm on the DBA/SQL side of the code. I could be useful as a QA tester however, since I've done that role in the past.
Thanks. Kevin
On Wednesday, August 11, 2021, 1:28:35 PM PDT, Junlin Chen ***@***.***> wrote:
great idea! I can see how users can benefit from both of your suggestion. This may not be prioritized anytime soon from the development team, however, if you would like to contribute to the project, we are more than happy to help get it through. :) 🙏
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Great! we need QA help for Superset releases for sure. How much time would you be able to contribute? @kevin-struckhoff |
This should be fairly simple using something like |
Right now I could spare about 10-12 hours a week. Is that enough? I'm in California and I usually get started w/ my superset work around 10:30 am PDT/PT. Right now I'm converting my OpenOffice charts to superset.
Thanks. Kevin
On Wednesday, August 11, 2021, 2:06:02 PM PDT, Junlin Chen ***@***.***> wrote:
Great! we need QA help for Superset releases for sure. How much time would you be able to contribute? @kevin-struckhoff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
That's exactly the behavior I'm looking for.
Thanks. Kevin
On Wednesday, August 11, 2021, 2:07:38 PM PDT, ʈᵃᵢ ***@***.***> wrote:
This should be fairly simple using something like
https://github.com/DylanVann/ant-design-draggable-modal
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Definitely enough! That will be great if you can contribute 10-12 hours per release! we just kick off the release vote in 1.3 but we lack QA help to push it through. Do you want to get on the release branch and start poking around? I can provide you with the basic test case :) 🙏🙏🙏🙏🙏🙏🙏🙏🙏 @kevin-struckhoff We will take care of the feature request :) Let's do it @geido 🙏, we should implement it ideally to all modal, if not possible, at least the view query in Dashboard :) Thank you @nytai as always <3 |
Ok how do I get on the release branch?
I did create a git clone on my test server and after a couple of hours getting the mysql_config file dependency error from make resolved and re-ran make again it seems to be working. I haven't tested anything yet.
Btw when I ran the command superset version it said 0.0.0dev.
Did I install it correctly? I'm not happy about the mysql_config file dependency issue. I had to install the community server V8 plus the mariadb-dev package which installed mysql_config finally. I found the missing file solution on stack overflow.com thankfully.
In any case let me know what I need to do to get started.
Sent from Yahoo Mail on Android
On Wed, Aug 11, 2021 at 6:31 PM, Junlin ***@***.***> wrote:
Right now I could spare about 10-12 hours a week. Is that enough? I'm in California and I usually get started w/ my superset work around 10:30 am PDT/PT. Right now I'm converting my OpenOffice charts to superset.
Definitely enough! That will be great if you can contribute 10-12 hours per release! we just kick off the release vote in 1.3 but we lack QA help to push it through. Do you want to get on the release branch and start poking around? I can provide you with the basic test case :) 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏 🙏
We will take care of the feature request :) Let's do it @geido 🙏 , we should implement it ideally to all modal, if not possible, at least the view query in Dashboard :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
@villebro can you direct @kevin-struckhoff to the right branch? @jinghua-qa can you provide the regression test case(the excel sheet)? 🙏 |
Thank you for helping! This is the spread sheet we used for testing, please feel free to let me know if you have any questions. https://docs.google.com/spreadsheets/d/1ghbmLdCkoaykAnoHPWpeXt-ow_PLitgTCOwtZeNSKBI/edit#gid=0 |
Hi, I'm building a new VM which will be running CentOS 8 for these tests. I'm reviewing the CONTRIBUTING.md file build the sofatware stack needed. Since this is my first time, any help would be appreciated. After the server is built, I'll install any needed OS dependencies and upgrade python and pip. Also, it appears that I'll need to install postgres, mysq, mariadb and docker-compose at least. Did I miss anything?
After that, I should be ready to install the Superset app. Which is the right way? I'm not going to make any code changes, just testing, at least for the time being. I may get involved in documentation updates later.
Thanks. Kevin
On Monday, August 23, 2021, 09:25:37 AM PDT, Junlin Chen ***@***.***> wrote:
@villebro can you direct @kevin-struckhoff to the right branch? @jinghua-qa can you provide the regression test case(the excel sheet)?
🙏
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Hi Jinghua, I've downloaded the spreadsheet. As soon as my test server is built, I'll start testing. I should be done withe build tomorrow.
Thanks. Kevin
On Monday, August 23, 2021, 09:37:47 AM PDT, jinghua-qa ***@***.***> wrote:
Thank you for helping! This is the spread sheet we used for testing, please feel free to let me know if you have any questions. https://docs.google.com/spreadsheets/d/1ghbmLdCkoaykAnoHPWpeXt-ow_PLitgTCOwtZeNSKBI/edit#gid=0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
Junlin, I was able to git clone the master source code tree and get it running using docker. This issue 16205 has already been closed and I can confirm that the new feature works fine. I used it in order to capture the screen shot in Issue 16486.
The bug I submitted in Issue 16204 has not been fixed. Please re-open. Sorting by a non-metric column is a must have. If it needs to a submitted feature request, let me know.
Thanks. Kevin
On Monday, August 23, 2021, 09:25:37 AM PDT, Junlin Chen ***@***.***> wrote:
@villebro can you direct @kevin-struckhoff to the right branch? @jinghua-qa can you provide the regression test case(the excel sheet)?
🙏
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
When the View Query Option is selected, the screen pops up in the middle of the web page and obscures the chart I'm working on. I'd like to be able to move it around so I can see the chart results and the query at the same time. It would be nice to also be able to resize the view query screen to minimize its' presence on the web page. There's a lot of blank space on the right side of the view query screen which further obscures the chart.
The text was updated successfully, but these errors were encountered: