Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Viewquery]Allow View Query Screen to move around #16205

Closed
kevin-struckhoff opened this issue Aug 11, 2021 · 13 comments · Fixed by #16394
Closed

[Viewquery]Allow View Query Screen to move around #16205

kevin-struckhoff opened this issue Aug 11, 2021 · 13 comments · Fixed by #16394
Assignees
Labels
enhancement:committed Enhancement planned / committed by a contributor explore Namespace | Anything related to Explore good first issue Good first issues for new contributors P2 Priority item - High

Comments

@kevin-struckhoff
Copy link

When the View Query Option is selected, the screen pops up in the middle of the web page and obscures the chart I'm working on. I'd like to be able to move it around so I can see the chart results and the query at the same time. It would be nice to also be able to resize the view query screen to minimize its' presence on the web page. There's a lot of blank space on the right side of the view query screen which further obscures the chart.
View-Query-Box-Obscures

@junlincc
Copy link
Member

great idea! I can see how users can benefit from both of your suggestion. This may not be prioritized anytime soon from the development team, however, if you would like to contribute to the project, we are more than happy to help get it through. :) 🙏

@junlincc junlincc added enhancement:request Enhancement request submitted by anyone from the community viz:explore:viewquery labels Aug 11, 2021
@kevin-struckhoff
Copy link
Author

kevin-struckhoff commented Aug 11, 2021 via email

@junlincc
Copy link
Member

Great! we need QA help for Superset releases for sure. How much time would you be able to contribute? @kevin-struckhoff

@junlincc junlincc added the good first issue Good first issues for new contributors label Aug 11, 2021
@nytai
Copy link
Member

nytai commented Aug 11, 2021

This should be fairly simple using something like
https://github.com/DylanVann/ant-design-draggable-modal

@kevin-struckhoff
Copy link
Author

kevin-struckhoff commented Aug 11, 2021 via email

@kevin-struckhoff
Copy link
Author

kevin-struckhoff commented Aug 11, 2021 via email

@junlincc
Copy link
Member

junlincc commented Aug 12, 2021

Right now I could spare about 10-12 hours a week. Is that enough? I'm in California and I usually get started w/ my superset work around 10:30 am PDT/PT. Right now I'm converting my OpenOffice charts to superset.

Definitely enough! That will be great if you can contribute 10-12 hours per release! we just kick off the release vote in 1.3 but we lack QA help to push it through. Do you want to get on the release branch and start poking around? I can provide you with the basic test case :) 🙏🙏🙏🙏🙏🙏🙏🙏🙏 @kevin-struckhoff

We will take care of the feature request :) Let's do it @geido 🙏, we should implement it ideally to all modal, if not possible, at least the view query in Dashboard :)

Thank you @nytai as always <3

@junlincc junlincc added P2 Priority item - High enhancement:committed Enhancement planned / committed by a contributor and removed enhancement:request Enhancement request submitted by anyone from the community labels Aug 12, 2021
@junlincc junlincc changed the title Allow View Query Screen to move around [Viewquery]Allow View Query Screen to move around Aug 12, 2021
@kevin-struckhoff
Copy link
Author

kevin-struckhoff commented Aug 12, 2021 via email

@junlincc
Copy link
Member

@villebro can you direct @kevin-struckhoff to the right branch? @jinghua-qa can you provide the regression test case(the excel sheet)?

🙏

@jinghua-qa
Copy link
Member

Thank you for helping! This is the spread sheet we used for testing, please feel free to let me know if you have any questions. https://docs.google.com/spreadsheets/d/1ghbmLdCkoaykAnoHPWpeXt-ow_PLitgTCOwtZeNSKBI/edit#gid=0

@kevin-struckhoff
Copy link
Author

kevin-struckhoff commented Aug 23, 2021 via email

@kevin-struckhoff
Copy link
Author

kevin-struckhoff commented Aug 23, 2021 via email

@kevin-struckhoff
Copy link
Author

kevin-struckhoff commented Aug 27, 2021 via email

@geido geido added explore Namespace | Anything related to Explore and removed viz:explore:viewquery labels Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:committed Enhancement planned / committed by a contributor explore Namespace | Anything related to Explore good first issue Good first issues for new contributors P2 Priority item - High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants