fix: setupPlugin in chart list page #16413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graceguo-supercat
force-pushed
the
gg-FixVizTypeDropdown
branch
2 times, most recently
from
a25765c
to
805b853
Compare
ktmud
approved these changes
Aug 23, 2021
|
@ktmud and @villebro, currently CI failed because of this error: is something wrong with country-map plugin? Or maybe i need to upgrade to a newer version? thanks! |
graceguo-supercat
force-pushed
the
gg-FixVizTypeDropdown
branch
from
805b853
to
b540183
Compare
graceguo-supercat
force-pushed
the
gg-FixVizTypeDropdown
branch
from
b540183
to
10478ff
Compare
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Aug 26, 2021
* upstream/master: (25 commits) chore(ci): bump pylint to 2.10.2 (apache#16463) fix: prevent page crash when chart can't render (apache#16464) chore: fixed slack invite link (apache#16466) fix(native-filters): handle null values in value filter (apache#16460) feat: add function list to auto-complete to Clickhouse datasource (apache#16234) refactor(explore): improve typing for Dnd controls (apache#16362) fix(explore): update overwrite button on perm change (apache#16437) feat: Draggable and Resizable Modal (apache#16394) refactor: sql_json view endpoint (apache#16441) fix(dashboard): undo and redo buttons weird alignment (apache#16417) fix: setupPlugin in chart list page (apache#16413) fix: Disable Slack notification method if no api token (apache#16367) feat: add Shillelagh DB engine spec (apache#16416) fix: copy to Clipboard order (apache#16299) docs: make FEATURE_FLAGS.md reference a link (apache#16415) chore(viz): bump superset-ui to 0.17.87 (apache#16420) feat: add activate command (apache#16404) Revert "fix(explore): let admin overwrite slice (apache#16290)" (apache#16408) fix(explore): retain chart ownership on query context update (apache#16419) chore: Removes the TODOs and uses the default page size (apache#16422) ...
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 26, 2021
* fix: setupPlugin in chart list page * fix the order of setupPlugins call * Fix jest test on loading geojson * add jest changes * fix unit tests Co-authored-by: Jesse Yang <[email protected]> (cherry picked from commit 08b8aa2)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* fix: setupPlugin in chart list page * fix the order of setupPlugins call * Fix jest test on loading geojson * add jest changes * fix unit tests Co-authored-by: Jesse Yang <[email protected]>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* fix: setupPlugin in chart list page * fix the order of setupPlugins call * Fix jest test on loading geojson * add jest changes * fix unit tests Co-authored-by: Jesse Yang <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is to fix issue found after #16285. See this comment #16285 (comment): the viz_type dropdown list became empty.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
after:
TESTING INSTRUCTIONS
CI and manual test.
ADDITIONAL INFORMATION