feat: add function list to auto-complete to Clickhouse datasource #16234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16234 +/- ##
==========================================
- Coverage 76.58% 76.48% -0.11%
==========================================
Files 1000 1000
Lines 53481 53508 +27
Branches 6815 6815
==========================================
- Hits 40958 40924 -34
- Misses 12287 12348 +61
Partials 236 236
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
zhaoyongjie
reviewed
Aug 13, 2021
zhaoyongjie
changed the title
…he#15477 Signed-off-by: Slach <[email protected]>
…he#15477 fix review comments apache#16234 (comment) Signed-off-by: Slach <[email protected]>
|
Hi @Slach, Thanks for the following updates. LGTM excepts CI didn't pass. Could you have got time to fix it? |
|
@zhaoyongjie try to fix CI/CD 33cbd25 |
I will trigger the CI. thanks! |
Signed-off-by: Slach <[email protected]>
|
@zhaoyongjie sorry, i forgot apply black formatter |
Signed-off-by: Slach <[email protected]>
|
@zhaoyongjie ;) i also apply |
Sure. |
|
@zhaoyongjie could you suggest about cypress-matrix tests? |
Cypress might be stuck in unknown reason. I will restart this job. |
|
@zhaoyongjie looks like all checks passed, could we merge pull request? |
zhaoyongjie
approved these changes
Aug 26, 2021
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Aug 26, 2021
* upstream/master: (25 commits) chore(ci): bump pylint to 2.10.2 (apache#16463) fix: prevent page crash when chart can't render (apache#16464) chore: fixed slack invite link (apache#16466) fix(native-filters): handle null values in value filter (apache#16460) feat: add function list to auto-complete to Clickhouse datasource (apache#16234) refactor(explore): improve typing for Dnd controls (apache#16362) fix(explore): update overwrite button on perm change (apache#16437) feat: Draggable and Resizable Modal (apache#16394) refactor: sql_json view endpoint (apache#16441) fix(dashboard): undo and redo buttons weird alignment (apache#16417) fix: setupPlugin in chart list page (apache#16413) fix: Disable Slack notification method if no api token (apache#16367) feat: add Shillelagh DB engine spec (apache#16416) fix: copy to Clipboard order (apache#16299) docs: make FEATURE_FLAGS.md reference a link (apache#16415) chore(viz): bump superset-ui to 0.17.87 (apache#16420) feat: add activate command (apache#16404) Revert "fix(explore): let admin overwrite slice (apache#16290)" (apache#16408) fix(explore): retain chart ownership on query context update (apache#16419) chore: Removes the TODOs and uses the default page size (apache#16422) ...
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…ache#16234) * add function list to auto-complete to Clickhouse datasource, fix apache#15477 Signed-off-by: Slach <[email protected]> * add function list to auto-complete to Clickhouse datasource, fix apache#15477 fix review comments apache#16234 (comment) Signed-off-by: Slach <[email protected]> * fix CI/CD https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235776 and https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235707 Signed-off-by: Slach <[email protected]> * fix black formatting Signed-off-by: Slach <[email protected]> * fix isort pre-commit hook Signed-off-by: Slach <[email protected]>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
…ache#16234) * add function list to auto-complete to Clickhouse datasource, fix apache#15477 Signed-off-by: Slach <[email protected]> * add function list to auto-complete to Clickhouse datasource, fix apache#15477 fix review comments apache#16234 (comment) Signed-off-by: Slach <[email protected]> * fix CI/CD https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235776 and https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235707 Signed-off-by: Slach <[email protected]> * fix black formatting Signed-off-by: Slach <[email protected]> * fix isort pre-commit hook Signed-off-by: Slach <[email protected]>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
add function list to auto-complete to Clickhouse datasource
Fixes #15477
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
use https://gist.github.com/Slach/ad926dfa30ceb4fe1d168c00c3da98e0#file-bootstrap-dev-sh
bootstrap-dev.shscriptopen https://localhost:8088
add
clickhouse+native://default@clickhouse:9000/defaultas new datasourceafter add, open SQLlab and try to use auto-complete