Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(viz): bump superset-ui to fix bugs in table and graph chart #14438

Merged
merged 5 commits into from
May 3, 2021
Merged

fix(viz): bump superset-ui to fix bugs in table and graph chart #14438

merged 5 commits into from
May 3, 2021

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented May 1, 2021 •
edited
Loading

SUMMARY

Bump superset-ui to fix bugs in table and graph chart.

What's included:

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See associated PRs.

TEST PLAN

Manual verification

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 1, 2021 •
edited
Loading

Codecov Report

Merging #14438 (091a54c) into master (2f9efb2) will not change coverage.
The diff coverage is n/a.

❗ Current head 091a54c differs from pull request most recent head 38c6e79. Consider uploading reports for the commit 38c6e79 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14438   +/-   ##
=======================================
  Coverage   76.95%   76.95%           
=======================================
  Files         955      955           
  Lines       48091    48091           
  Branches     6036     6036           
=======================================
  Hits        37008    37008           
  Misses      10884    10884           
  Partials      199      199
Flag Coverage Δ
javascript 71.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f9efb2...38c6e79. Read the comment docs.

@ktmud
Copy link
Member Author

ktmud commented May 1, 2021

/testenv up

@ktmud ktmud marked this pull request as ready for review May 1, 2021 01:53
@ktmud
Copy link
Member Author

ktmud commented May 1, 2021

/testenv up

villebro
villebro approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming those CI failures are flakes)

@ktmud
Copy link
Member Author

ktmud commented May 3, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

@ktmud Ephemeral environment spinning up at http://34.215.76.204:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@ktmud ktmud mentioned this pull request May 3, 2021
Closed
8 tasks
@ktmud
Copy link
Member Author

ktmud commented May 3, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

@ktmud Ephemeral environment spinning up at http://54.245.191.35:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@ktmud ktmud merged commit a75e4af into master May 3, 2021
@ktmud ktmud deleted the viz-bugfixes branch May 3, 2021 23:23
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2021

Ephemeral environment shutdown and build artifacts deleted.

amitmiran137 pushed a commit that referenced this pull request May 4, 2021
@ktmud
fix(viz): bump superset-ui to fix bugs in table and graph chart (#14438)
19ca78f 
(cherry picked from commit a75e4af)
hughhhh pushed a commit that referenced this pull request May 4, 2021
@ktmud @hughhhh
fix(viz): bump superset-ui to fix bugs in table and graph chart (#14438)
61427a4
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Sep 8, 2021
@ktmud @cccs-RyanS
fix(viz): bump superset-ui to fix bugs in table and graph chart (apac…
2c6b22c 
…he#14438)

(cherry picked from commit a75e4af)
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@ktmud
fix(viz): bump superset-ui to fix bugs in table and graph chart (apac…
0695736 
…he#14438)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@ktmud
fix(viz): bump superset-ui to fix bugs in table and graph chart (apac…
0470489 
…he#14438)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@ktmud
fix(viz): bump superset-ui to fix bugs in table and graph chart (apac…
649fd08 
…he#14438)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v1.2 🍒 1.2.0 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ktmud @villebro @mistercrunch @amitmiran137