fix(plugin-chart-table): resize and totals formatting bug #1082
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/2DeZH5icwLSJeFmJcMdQ7ZxGuHAT |
ktmud
force-pushed
the
table-totals-bugfix
branch
from
6fcea8b to
15fe468
Compare
Codecov Report
@@ Coverage Diff @@
## master #1082 +/- ##
==========================================
- Coverage 27.80% 27.79% -0.01%
==========================================
Files 453 453
Lines 9104 9108 +4
Branches 1416 1418 +2
==========================================
+ Hits 2531 2532 +1
- Misses 6381 6384 +3
Partials 192 192
Continue to review full report at Codecov.
|
ktmud
force-pushed
the
table-totals-bugfix
branch
from
15fe468 to
252adde
Compare
| data={data} | ||
| rowCount={rowCount} | ||
| tableClassName="table table-striped table-condensed" | ||
| pageSize={pageSize} | ||
| serverPaginationData={serverPaginationData} | ||
| pageSizeOptions={pageSizeOptions} | ||
| width={width} |
There was a problem hiding this comment.
This was accidentally deleted here:
2af6a24#diff-1b5ecf1086dbd4b0e942970dc4e4b20077a2d30d6046d08444b46d8cb57de2a4L303
| {footerGroup.headers.map(column => column.render('Footer', { key: column.id }))} | ||
| </tr> | ||
| ); | ||
| })} |
There was a problem hiding this comment.
Changed to use react-table's built-in footer support to render totals. cc @kgabryje
|
That would be awesome. Thanks for the headsup. |
🐛 Bug Fix
Fixes two bugs:
Also updates the tooltip for the column width control to be more reflective of what it really is.
Before
After