fix: annotation modal dateRangePicker saved invalid value #13969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13969 +/- ##
==========================================
- Coverage 78.96% 78.96% -0.01%
==========================================
Files 936 936
Lines 47409 47408 -1
Branches 5941 5940 -1
==========================================
- Hits 37438 37437 -1
Misses 9844 9844
Partials 127 127
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
nytai
approved these changes
Apr 6, 2021
| @@ -311,14 +311,13 @@ const AnnotationModal: FunctionComponent<AnnotationModalProps> = ({ | |||
| <span className="required">*</span> | |||
| </div> | |||
| <RangePicker | |||
| format="YYYY-MM-DD hh:mm a" | |||
| format="YYYY-MM-DD HH:mm" | |||
There was a problem hiding this comment.
We should start collecting these formats in a module.
michael-s-molina
approved these changes
Apr 7, 2021
zhaoyongjie
force-pushed
the
fix_annotation_daterange_picker
branch
from
1a15e2d to
805aef1
Compare
allanco91
pushed a commit
to allanco91/superset
that referenced
this pull request
May 21, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Since moment.js cannot parse
YYY-MM-DD hh:mm aformat, an error will occur.Now we use a consistent format for saving and parsing datetime object.
closes: #13958
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
After
TEST PLAN
ADDITIONAL INFORMATION