Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Annotation]Adding annotation date picker shows "Invalid date" #13958

Closed
3 tasks done
razzius opened this issue Apr 6, 2021 · 0 comments · Fixed by #13969
Closed
3 tasks done

[Annotation]Adding annotation date picker shows "Invalid date" #13958

razzius opened this issue Apr 6, 2021 · 0 comments · Fixed by #13969
Labels
#bug Bug report explore:annotation Related to annotations in Explore

Comments

@razzius
Copy link

razzius commented Apr 6, 2021

Adding a new annotation fails because selecting a date gives "Invalid date"

Expected results

Dates are reflected in the UI field

Actual results

UI field shows "Invalid date" and calendar turns into a bunch of NaN

Screenshots

image

image

How to reproduce the bug

(starting with docker-compose up)

  1. Go to Settings > Annotation layers
  2. Click on '+ Annotation Layer'
  3. Add a name, click ADD
  4. Click '+ Annotation'
  5. Click 'Start date' field
  6. Enter any date for start and end
  7. Click OK
  8. Notice field says "Invalid date" and the calendar that pops up only has NaN
  9. If you click ADD anyways, an error pops up with "An error occurred while creating annotations: (end_dttm) Not a valid datetime.
    (start_dttm) Not a valid datetime."

Environment

(please complete the following information):

  • superset version: f19f2c3 (current master)
  • python version: python 3.7.9
  • node.js version: 14.16.0

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@razzius razzius added the #bug Bug report label Apr 6, 2021
@junlincc junlincc changed the title Adding annotation date picker shows "Invalid date" [Explore]Adding annotation date picker shows "Invalid date" Apr 6, 2021
@zhaoyongjie zhaoyongjie changed the title [Explore]Adding annotation date picker shows "Invalid date" [Annotation]Adding annotation date picker shows "Invalid date" Apr 6, 2021
@junlincc junlincc added the explore:annotation Related to annotations in Explore label Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report explore:annotation Related to annotations in Explore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants