fix: prior npm font source had a glitch #11724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11724 +/- ##
=======================================
Coverage 63.04% 63.04%
=======================================
Files 895 895
Lines 43315 43315
Branches 4015 4015
=======================================
Hits 27308 27308
Misses 15829 15829
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
mistercrunch
approved these changes
Nov 17, 2020
|
Also "Q" |
villebro
pushed a commit
to preset-io/superset
that referenced
this pull request
Nov 17, 2020
villebro
pushed a commit
that referenced
this pull request
Nov 17, 2020
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
3 tasks
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🍒 0.38.0
🍒 0.38.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Welp, the fonts in #11718 almost worked out quite nicely, but there's an issue with the boolean vector intersection of the uppercase A for some reason. Upon reading further, that font library is on a path to deprecation (ugh) and they recommend the one used in this PR instead. So, here we go!
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION