Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken webfonts: ‘url([object Module])’ in @font-face #10786

Closed
2 of 3 tasks
Clockmaker opened this issue Sep 3, 2020 · 3 comments
Closed
2 of 3 tasks

Broken webfonts: ‘url([object Module])’ in @font-face #10786

Clockmaker opened this issue Sep 3, 2020 · 3 comments
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@Clockmaker
Copy link

Hi,
I was updating superset to 0.37 and I noticed that all the webfonts are broken

On firefox 78 there is also this warning:
Unknown descriptor ‘url([object Module])’ in @font-face rule. Skipped to next declaration.

I gave a look at the css generated by less-loader and indeed all the font-face are broken starting from 0.37 onwards.

2020-09-03-210245_3840x1080_scrot

How to reproduce the bug

docker run -it preset/superset:0.37 /bin/bash

inside the container:

grep -r "object Module" /app/superset/static/assets/ --color="auto"

I also pulled the 38da552a57b9be999fb36b2cf7ae1c9231a010eb (14 days old) with the same result.

Checklist

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

I compared webpack.config, package.json and Dockerfile with the 0.36 but I fail to see any possible breaking change.

Possible solution

I tried to add esModule: false to less-loader and it seems to solve the issue (partially, because I still have some warnings).

Thanks.

@Clockmaker Clockmaker added the !deprecated-label:bug Deprecated label - Use #bug instead label Sep 3, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@junlincc
Copy link
Member

junlincc commented Sep 4, 2020

@rusackas

@rusackas
Copy link
Member

This was resolved with #11718 and #11724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

No branches or pull requests

3 participants