Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dataset editor improvement #10444

Merged
merged 5 commits into from
Aug 4, 2020

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Jul 27, 2020

SUMMARY

  • move add item button to top
  • increase the size of SQL Expression
  • add placeholder text
  • change x to delete icon

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
Screen Shot 2020-07-28 at 10 31 26 AM
Screen Shot 2020-07-27 at 3 45 59 PM
Screen Shot 2020-07-28 at 10 40 48 AM

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

Codecov Report

Merging #10444 into master will decrease coverage by 11.19%.
The diff coverage is 72.83%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #10444       +/-   ##
===========================================
- Coverage   70.25%   59.05%   -11.20%     
===========================================
  Files         605      409      -196     
  Lines       32377    13316    -19061     
  Branches     3271     3273        +2     
===========================================
- Hits        22745     7864    -14881     
+ Misses       9522     5263     -4259     
- Partials      110      189       +79     
Flag Coverage Δ
#cypress ?
#javascript 59.05% <72.83%> (-0.02%) ⬇️
#python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/datasource/DatasourceEditor.jsx 61.25% <ø> (-8.13%) ⬇️
...nd/src/explore/components/controls/TextControl.tsx 17.85% <33.33%> (ø)
superset-frontend/src/components/EditableTitle.tsx 74.28% <74.28%> (ø)
superset-frontend/src/CRUD/CollectionTable.jsx 63.46% <75.00%> (-22.68%) ⬇️
superset-frontend/src/SqlLab/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/App.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/explore/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/dashboard/index.jsx 0.00% <0.00%> (-100.00%) ⬇️
superset-frontend/src/setup/setupColors.js 0.00% <0.00%> (-100.00%) ⬇️
... and 343 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f56cd5...45f8a73. Read the comment docs.

@@ -83,18 +83,23 @@ function ColumnCollectionTable({
<Field
fieldKey="expression"
label={t('SQL Expression')}
control={<TextControl />}
control={
<TextAreaControl
Copy link
Member

@mistercrunch mistercrunch Jul 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looked pretty big in the <tr>, would look bad if there was many of these stacked... We may want to inline it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update the sql expression field to half the size

@lilykuang lilykuang force-pushed the lily/dataset-editor-improvement branch from 45f8a73 to 92e4fa4 Compare July 28, 2020 17:24
@lilykuang lilykuang marked this pull request as ready for review July 28, 2020 19:45
@willbarrett willbarrett requested a review from nytai August 3, 2020 17:31
Copy link
Member

@willbarrett willbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if it LGT @nytai let's merge.

Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nytai nytai merged commit fa07506 into apache:master Aug 4, 2020
@nytai nytai deleted the lily/dataset-editor-improvement branch August 4, 2020 18:52
Ofeknielsen pushed a commit to ofekisr/incubator-superset that referenced this pull request Oct 5, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants