Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add Item" button in Datasource Editor too big #10838

Closed
3 tasks
ktmud opened this issue Sep 11, 2020 · 4 comments · Fixed by #10983
Closed
3 tasks

"Add Item" button in Datasource Editor too big #10838

ktmud opened this issue Sep 11, 2020 · 4 comments · Fixed by #10983
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@ktmud
Copy link
Member

ktmud commented Sep 11, 2020

"Add Item" button in Datasource Editor seems too big and ran out of the last column in the Metrics tab.

Expected results

Button doesn't overflow.

Actual results

Screenshots

image

How to reproduce the bug

  1. Go to edit any datasource in the Explore page.

Environment

(please complete the following information):

  • superset version: superset version
  • python version: python --version
  • node.js version: node -v
  • npm version: npm -v

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.

@ktmud ktmud added the !deprecated-label:bug Deprecated label - Use #bug instead label Sep 11, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.83. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@junlincc
Copy link
Member

junlincc commented Sep 12, 2020

@lilykuang hey Lily, this relates to your dataset editor improvement probably? could you please take a look? 🙏

@nytai
Copy link
Member

nytai commented Sep 12, 2020

this was likely introduced in a3e2e65#diff-43b9aaf2f0ad9833ac0362f7beb20235R749

@junlincc
Copy link
Member

resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants