Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): fixes perf on charts and introduces sorting by db on datasets #10392

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

dpgaspar
Copy link
Member

SUMMARY

Fixes a performance bug on charts and introduces sorting by database on datasets

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

Codecov Report

Merging #10392 into master will decrease coverage by 0.77%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10392      +/-   ##
==========================================
- Coverage   70.52%   69.75%   -0.78%     
==========================================
  Files         603      196     -407     
  Lines       32421    19025   -13396     
  Branches     3297        0    -3297     
==========================================
- Hits        22865    13270    -9595     
+ Misses       9452     5755    -3697     
+ Partials      104        0     -104     
Flag Coverage Δ
#cypress ?
#javascript ?
#python 69.75% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/sqla/models.py 89.45% <ø> (-0.05%) ⬇️
superset/datasets/api.py 92.14% <ø> (ø)
superset/models/slice.py 84.65% <100.00%> (ø)
...uperset-frontend/src/utils/getClientErrorObject.ts
superset-frontend/src/setup/setupApp.ts
...end/src/dashboard/components/dnd/DragDroppable.jsx
superset-frontend/src/components/ModalTrigger.jsx
...perset-frontend/src/middleware/loggerMiddleware.js
...rontend/src/dashboard/util/componentIsResizable.ts
.../src/dashboard/components/menu/PopoverDropdown.jsx
... and 399 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9611086...53e4c0c. Read the comment docs.

Copy link
Member

@nytai nytai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nytai nytai merged commit 2fd37b1 into apache:master Jul 23, 2020
@nytai nytai deleted the fix/dataset-database branch July 23, 2020 18:20
@dpgaspar dpgaspar added the v0.37 label Jul 26, 2020
@villebro villebro removed the v0.37 label Jul 27, 2020
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.38.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants