fix(api): fixes perf on charts and introduces sorting by database on …

…datasets (#10392)
apache · Jul 23, 2020 · 2fd37b1 · 2fd37b1
1 parent e026406
commit 2fd37b1
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 12 deletions.
diff --git a/superset-frontend/src/views/datasetList/DatasetList.tsx b/superset-frontend/src/views/datasetList/DatasetList.tsx
@@ -54,7 +54,10 @@ type Dataset = {
   changed_by_url: string;
   changed_by: string;
   changed_on_delta_humanized: string;
-  database_name: string;
+  database: {
+    id: string;
+    database_name: string;
+  };
   explore_url: string;
   id: number;
   owners: Array<Owner>;
@@ -275,8 +278,7 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
     },
     {
       Header: t('Source'),
-      accessor: 'database_name',
-      disableSortBy: true,
+      accessor: 'database.database_name',
       size: 'lg',
     },
     {

diff --git a/superset/connectors/sqla/models.py b/superset/connectors/sqla/models.py
@@ -493,10 +493,6 @@ def description_markeddown(self) -> str:
     def datasource_name(self) -> str:
         return self.table_name
 
-    @property
-    def database_name(self) -> str:
-        return self.database.name
-
     @classmethod
     def get_datasource_by_name(
         cls,

diff --git a/superset/datasets/api.py b/superset/datasets/api.py
@@ -72,8 +72,8 @@ class DatasetRestApi(BaseSupersetModelRestApi):
     }
     list_columns = [
         "id",
-        "database_id",
-        "database_name",
+        "database.id",
+        "database.database_name",
         "changed_by_name",
         "changed_by_url",
         "changed_by.first_name",
@@ -97,6 +97,7 @@ class DatasetRestApi(BaseSupersetModelRestApi):
         "schema",
         "changed_by.first_name",
         "changed_on_delta_humanized",
+        "database.database_name",
     ]
     show_columns = [
         "database.database_name",

diff --git a/superset/models/slice.py b/superset/models/slice.py
@@ -269,7 +269,7 @@ def slice_link(self) -> Markup:
 
     @property
     def changed_by_url(self) -> str:
-        return f"/superset/profile/{self.created_by.username}"  # type: ignore
+        return f"/superset/profile/{self.changed_by.username}"  # type: ignore
 
     @property
     def icons(self) -> str:

diff --git a/tests/datasets/api_tests.py b/tests/datasets/api_tests.py
@@ -92,8 +92,7 @@ def test_get_dataset_list(self):
             "changed_by_url",
             "changed_on_delta_humanized",
             "changed_on_utc",
-            "database_id",
-            "database_name",
+            "database",
             "default_endpoint",
             "explore_url",
             "id",