chore: type FilterableTable #10073
Merged
chore: type FilterableTable #10073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10073 +/- ##
==========================================
+ Coverage 70.49% 70.51% +0.01%
==========================================
Files 585 585
Lines 31073 31096 +23
Branches 3185 3191 +6
==========================================
+ Hits 21905 21927 +22
Misses 9058 9058
- Partials 110 111 +1
Continue to review full report at Codecov.
|
ktmud
reviewed
Jun 18, 2020
superset-frontend/src/components/FilterableTable/FilterableTable.tsx
Outdated
Show resolved
Hide resolved
ktmud
approved these changes
Jun 18, 2020
| this.setState({ sortBy, sortDirection }); | ||
| } | ||
|
|
||
| fitTableToWidthIfNeeded() { | ||
| const containerWidth = this.container.clientWidth; | ||
| const containerWidth = this.container.current!.clientWidth; |
There was a problem hiding this comment.
this.container was the same createRef before. Does this mean this code used to not work?
There was a problem hiding this comment.
unclear to be honest. I think I should trust TypeScript's typing here though, and not having current threw an error
etr2460
force-pushed
the
erik-ritter--type-src-components-filterabletable
branch
from
80ce615 to
1c2a409
Compare
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As titled. Related to #10004
TEST PLAN
ADDITIONAL INFORMATION
to: @ktmud @nytai @graceguo-supercat