chore: type FilterableTable (#10073)

apache · Jun 19, 2020 · 2e76fbb · 2e76fbb
1 parent a6390af
commit 2e76fbb
Show file tree

Hide file tree

Showing 4 changed files with 180 additions and 63 deletions.
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
@@ -101,9 +101,11 @@
     "@superset-ui/translation": "^0.13.27",
     "@superset-ui/validator": "^0.13.27",
     "@types/classnames": "^2.2.9",
+    "@types/enzyme": "^3.10.5",
     "@types/react-bootstrap": "^0.32.21",
     "@types/react-json-tree": "^0.6.11",
     "@types/react-select": "^3.0.12",
+    "@types/react-virtualized": "^9.21.10",
     "@types/react-window": "^1.8.2",
     "@types/redux-localstorage": "^1.0.8",
     "@types/rison": "0.0.6",

diff --git a/.../FilterableTable/FilterableTable_spec.jsx → .../FilterableTable/FilterableTable_spec.tsx b/.../FilterableTable/FilterableTable_spec.jsx → .../FilterableTable/FilterableTable_spec.tsx
@@ -17,7 +17,7 @@
  * under the License.
  */
 import React from 'react';
-import { mount } from 'enzyme';
+import { mount, ReactWrapper } from 'enzyme';
 import FilterableTable, {
   MAX_COLUMNS_FOR_TABLE,
 } from 'src/components/FilterableTable/FilterableTable';
@@ -32,7 +32,7 @@ describe('FilterableTable', () => {
     ],
     height: 500,
   };
-  let wrapper;
+  let wrapper: ReactWrapper;
   beforeEach(() => {
     wrapper = mount(<FilterableTable {...mockedProps} />);
   });
@@ -53,11 +53,11 @@ describe('FilterableTable', () => {
         (_, x) => `col_${x}`,
       ),
       data: [
-        Object.assign(
+        {
           ...Array.from(Array(wideTableColumns)).map((val, x) => ({
             [`col_${x}`]: x,
           })),
-        ),
+        },
       ],
       height: 500,
     };