Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the schema of short url is hard code to http #4656

Closed
ktong opened this issue Mar 21, 2018 · 3 comments
Closed

the schema of short url is hard code to http #4656

ktong opened this issue Mar 21, 2018 · 3 comments
Labels
!deprecated-label:bug Deprecated label - Use #bug instead good first issue Good first issues for new contributors

Comments

@ktong
Copy link
Contributor

ktong commented Mar 21, 2018

https://github.com/apache/incubator-superset/blob/93ec76f7570dcd53d110498cc18ec0f15dd9854b/superset/views/core.py#L750
@mistercrunch mistercrunch added !deprecated-label:bug Deprecated label - Use #bug instead help wanted labels Apr 10, 2018
@ripoul
Copy link
Contributor

ripoul commented Apr 25, 2018 •
edited
Loading

this code should do the work :

scheme = request.scheme  
return Response(  
            '{scheme}://{request.headers[Host]}/{directory}?r={obj.id}'.format(  
             scheme = scheme, request=request, directory=directory, obj=obj),  
            mimetype='text/plain')

@mistercrunch
Copy link
Member

@ripoul mind submitting a PR ?

mistercrunch pushed a commit that referenced this issue Apr 27, 2018
@ripoul @mistercrunch
remove hard code http scheme of short url #4656 (#4886)
510ae84 
* remove hard code http scheme of short url #4656

* remove space

* add space

* remove temp var
@ripoul
Copy link
Contributor

ripoul commented Apr 27, 2018

@mistercrunch done and merge! Close?

michellethomas pushed a commit to michellethomas/panoramix that referenced this issue May 24, 2018
@ripoul @michellethomas
remove hard code http scheme of short url apache#4656 (apache#4886)
2d86443 
* remove hard code http scheme of short url apache#4656

* remove space

* add space

* remove temp var
timifasubaa pushed a commit to timifasubaa/incubator-superset that referenced this issue May 31, 2018
@ripoul @timifasubaa
remove hard code http scheme of short url apache#4656 (apache#4886)
e95961e 
* remove hard code http scheme of short url apache#4656

* remove space

* add space

* remove temp var
wenchma pushed a commit to wenchma/incubator-superset that referenced this issue Nov 16, 2018
@ripoul @mistercrunch
remove hard code http scheme of short url apache#4656 (apache#4886)
cf217a6 
* remove hard code http scheme of short url apache#4656

* remove space

* add space

* remove temp var
@graceguo-supercat graceguo-supercat mentioned this issue Jul 11, 2019
Closed
11 tasks
@mistercrunch mistercrunch added the good first issue Good first issues for new contributors label Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
!deprecated-label:bug Deprecated label - Use #bug instead good first issue Good first issues for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mistercrunch @ktong @ripoul