update shortner endpoint to look at request headers origin instead of host #7840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rahul-rahul-sp what is purpose of this code change? |
|
hi @graceguo-supercat , it is a question i asked here. i wanted to get the community's take on this.the PR is just to show the change. |
graceguo-supercat
requested changes
Jul 11, 2019
superset/views/core.py
Outdated
| @@ -1008,7 +1008,7 @@ def shortner(self): | |||
| db.session.add(obj) | |||
| db.session.commit() | |||
| return Response( | |||
| "{scheme}://{request.headers[Host]}/r/{obj.id}".format( | |||
| "{request.headers[origin]}/r/{obj.id}".format( | |||
There was a problem hiding this comment.
I am ok to use ORIGIN instead of HOST, why remove {scheme} part?
Also please check the error message in unit test, you probably need to find a way to get HTTP_ORIGIN header
There was a problem hiding this comment.
i will double check on the schema but in my local testing it was getting added automatically.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Origin
|
follow up PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Update shortner url for to look at the origin request header instead of host.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Tested locally
ADDITIONAL INFORMATION
REVIEWERS