Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][build] Revert "Upgrade jackson version to 2.15.0 for CVE-2022-1471 (#20177)" #20182

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Apr 26, 2023

This reverts commit fd60e9e.

Motivation

There's a regression of Jackson.
FasterXML/jackson-databind#3874

Modifications

  • Revert upgrading operation
  • doc-not-needed

Verifying this change

  • Make sure that the change passes the CI checks.

@github-actions
Copy link

@mattisonchao Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@mattisonchao mattisonchao added this to the 3.1.0 milestone Apr 26, 2023
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Apr 26, 2023
@mattisonchao mattisonchao reopened this Apr 26, 2023
@Technoboy- Technoboy- changed the title Revert "[improve][build] Upgrade jackson version to 2.15.0 for CVE-2022-1471 (#20177)" [improve][build] Revert "Upgrade jackson version to 2.15.0 for CVE-2022-1471 (#20177)" Apr 26, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #20182 (db13ac0) into master (fd60e9e) will increase coverage by 39.86%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #20182       +/-   ##
=============================================
+ Coverage     33.11%   72.98%   +39.86%     
- Complexity    12223    31976    +19753     
=============================================
  Files          1499     1868      +369     
  Lines        114461   138468    +24007     
  Branches      12429    15236     +2807     
=============================================
+ Hits          37906   101062    +63156     
+ Misses        71618    29374    -42244     
- Partials       4937     8032     +3095     
Flag Coverage Δ
inttests 24.14% <100.00%> (?)
systests 24.74% <100.00%> (?)
unittests 72.28% <100.00%> (+39.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/org/apache/pulsar/common/util/FieldParser.java 85.95% <100.00%> (+57.85%) ⬆️

... and 1540 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants