Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][build] Upgrade jackson version to 2.15.0 for CVE-2022-1471 #20177

Merged
merged 3 commits into from
Apr 25, 2023
Merged

[improve][build] Upgrade jackson version to 2.15.0 for CVE-2022-1471 #20177

merged 3 commits into from
Apr 25, 2023

Conversation

mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Apr 25, 2023

Modifications

  • Upgrade jackson version to 2.15.0

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if #20085 already fixes CVE-2022-1471?

cc @Technoboy-

@Technoboy-
Copy link
Contributor

I wonder if #20085 already fixes CVE-2022-1471?

cc @Technoboy-

Yes, fixed, but it's better also to accept this. because Jackson-2.15.0 is released yesterday.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Then let's update the PR title for upgrading only.

... while I'd prefer wait a bit for new version tested instead of greedy upgrade when unnecessary.

@tisonkun tisonkun changed the title Upgrade jackson version to 2.15.0 to fix CVE-2022-1471 [improve][build] Upgrade jackson version to 2.15.0 Apr 25, 2023
@tisonkun
Copy link
Member

After an offline discussion with @mattisonchao I notice that jackson-dataformat-yaml 2.14.2 still depend on snakeyaml 1.33 so this patch does fix a CVE.

@tisonkun tisonkun changed the title [improve][build] Upgrade jackson version to 2.15.0 [improve][build] Upgrade jackson version to 2.15.0 for CVE-2022-1471 Apr 25, 2023
@Technoboy-
Copy link
Contributor

Technoboy- commented Apr 25, 2023

After an offline discussion with @mattisonchao I notice that jackson-dataformat-yaml 2.14.2 still depend on snakeyaml 1.33 so this patch does fix a CVE.

yes, right. Sorry for not declaring this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants