HDDS-5279. OFS mkdir -p does not work when Volume is not pre-created #2412
Conversation
Change-Id: I9e59ec7c2c895dd3c70ef20e6beba4a113ea2f24
Change-Id: Ifb321f6d1278c8c48c282876be586220cfcd288c
Change-Id: I9c288a4ffa66a66a25819282d6a09fedfae1fba9
| // when ACL is disabled. Both exceptions need to be handled. | ||
| switch (ex.getResult()) { | ||
| case VOLUME_NOT_FOUND: | ||
| case BUCKET_NOT_FOUND: |
There was a problem hiding this comment.
The case where volume is not found should not be as common as bucket not found. I think it would be better to avoid the redundant call to create volume.
There was a problem hiding this comment.
Thanks for the comment @kerneltime .
VOLUME_NOT_FOUND is actually frequently encountered during testing where we create volume+bucket+directories on one shot with mkdir -p when ACL is enabled.
If you think about it, in both cases the action(s) we need to take is the same. i.e. volume needs to be created.
It's just that the exception thrown from the call proxy.getBucketDetails is different -- which is bizzare, and we maybe want to fix getBucketDetails's behavior at some point (for example, to always throw VOLUME_NOT_FOUND regardless of whether ACL is enabled or not), after which we can throw away case BUCKET_NOT_FOUND.
There was a problem hiding this comment.
Do you want to create a newbie jira to clean up the behavior to send the appropriate error which is the right fix.
There was a problem hiding this comment.
Yes I will file one. but probably not a newbie one since changing that could involve a series of changes -- throwing a different exception can break other existing behaviors.
Change-Id: Id2a5bca01f7300a4c190f0f16a9cc09e00644f62
|
@smengcl , correct if i m wrong. Volumes in ozone are supposed to be created by admins only as per the doc. Are we going to break this notion here? |
Nope. The behavior hasn't changed. This is client code. Server (OM) is responsible for checking if the client has the permission to create a volume. In this case, if a regular user (non-admin) tries to do |
|
Thanks @kerneltime and @avijayanhwx for the reviews. I have merged this. |
* master: (48 commits) HDDS-5514. Skip check for UNHEALTHY containers for datanode finalize. (apache#2469) HDDS-5279. OFS mkdir -p does not work when Volume is not pre-created (apache#2412) HDDS-5328. Remove delete container command from admin CLI (apache#2456) HDDS-5382. Increase default container report interval to 60 mins (apache#2363) HDDS-5378 Add APIs to retrieve Namespace Summary from Recon (apache#2417) HDDS-5466. Refactor BlockOutputStream. (apache#2442) HDDS-5465. Delete redundant code when set、add and remove bucket acl (apache#2439) HDDS-5184. Use separate DB profile for Datanodes. (apache#2214) HDDS-5494. Reduce retry in Kubernetes test (apache#2461) HDDS-5414. Data buffers incorrectly filtered for Ozone Insight (apache#2387) HDDS-5450. Avoid refresh pipeline for S3 headObject (apache#2431) HDDS-5500. New k3s version breaks kubernetes test (apache#2464) HDDS-5489. Install OS-specific flekszible (apache#2462) Multi-raft style placement with permutations for offline data generator (apache#2434) HDDS-5484. Intermittent failure in TestReplicationManager#testMovePrerequisites (apache#2454) HDDS-5443 Create and then recreate a bucket with a randomized name (apache#2436) HDDS-5492. Disable failing kubernetes test (apache#2459) HDDS-4330. Bootstrap new OM node (apache#1494) HDDS-5418. Let Recon send reregisterCommand to Datanodes if DatanodeDetails changed (apache#2392) HDDS-5479. s3g bucket list failed when there is non-english key name. (apache#2450) ...
https://issues.apache.org/jira/browse/HDDS-5279
ClientProtocol#getBucketDetailscan throwVOLUME_NOT_FOUNDwhen ACL is enabled becausecheckAcls()will attempt to retrieve volume owner with getVolumeOwner(), whichgetBucket()didn't handle previously.Thanks @avijayanhwx for the initial fix.
Updated the UT with new parameter.