-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-5382. Increase default container report interval to 60 mins #2363
Conversation
Hi @sadanand48 , sorry to disturb, but I happen to see this and can't help wonder why the default report intervals are changed? I can't find any descriptions in the related jira either, could you please explain a bit? thanks~ |
@guihecheng , during scale testing of ozone with 350k+ containers and nearly 1 million replica reports it was observed that, there is a sudden burst in scm heap usage . In hdfs, the fill block report interval is 6 hours by default and in between, there are incremental bock reports. Similarly, there are incremental reports in SCM . Setting the full container report interval to 1 hour make things quite stable as determined from tests and 60s for full report seems very aggressive. |
@sadanand48 , please change the default container and pipeline report interval to 60s in acceotance tests and in MiniOzoneCluster so that there are no random/intermittent failures bcoz of this. |
Thanks @bshashikant for the explanation, this is very useful pr for a production deployment. |
@sadanand48 , can you elaborate a bit why pipeline report interval is changed to 60m? If I remember correctly, today, Pipeline Manager will use this pipeline report interval as the timeout to wait for a pipeline be ready for serve wright. |
maybe for now , we could just only change container full report interval , which is a heavy burden of scm. |
I think, the pipeline report is sent on heartbeat as soon as a pipeline is created or pipeline is closed and destroyed. There is no dependency on the pipeline report interval as such for opening up the pipeline for write. Full report intervals can be sent a higher interval. |
@nandakumar131 , can you also have a look? |
I support increasing the default interval. @ChenSammi feel free to let us know if something is still holding back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changing this to only the container report interval.
The last patch LGTM, +1. |
* master: (48 commits) HDDS-5514. Skip check for UNHEALTHY containers for datanode finalize. (apache#2469) HDDS-5279. OFS mkdir -p does not work when Volume is not pre-created (apache#2412) HDDS-5328. Remove delete container command from admin CLI (apache#2456) HDDS-5382. Increase default container report interval to 60 mins (apache#2363) HDDS-5378 Add APIs to retrieve Namespace Summary from Recon (apache#2417) HDDS-5466. Refactor BlockOutputStream. (apache#2442) HDDS-5465. Delete redundant code when set、add and remove bucket acl (apache#2439) HDDS-5184. Use separate DB profile for Datanodes. (apache#2214) HDDS-5494. Reduce retry in Kubernetes test (apache#2461) HDDS-5414. Data buffers incorrectly filtered for Ozone Insight (apache#2387) HDDS-5450. Avoid refresh pipeline for S3 headObject (apache#2431) HDDS-5500. New k3s version breaks kubernetes test (apache#2464) HDDS-5489. Install OS-specific flekszible (apache#2462) Multi-raft style placement with permutations for offline data generator (apache#2434) HDDS-5484. Intermittent failure in TestReplicationManager#testMovePrerequisites (apache#2454) HDDS-5443 Create and then recreate a bucket with a randomized name (apache#2436) HDDS-5492. Disable failing kubernetes test (apache#2459) HDDS-4330. Bootstrap new OM node (apache#1494) HDDS-5418. Let Recon send reregisterCommand to Datanodes if DatanodeDetails changed (apache#2392) HDDS-5479. s3g bucket list failed when there is non-english key name. (apache#2450) ...
What changes were proposed in this pull request?
During scale testing of ozone with 350k+ containers and nearly 1 million replica reports it was observed that, there is a sudden burst in SCM heap usage . In HDFS, the full block report interval is 6 hours by default and in between, there are incremental block reports. Similarly, there are incremental reports in SCM . Setting the full container report interval to 1 hour make things quite stable as determined from tests and 60s for full report seems very aggressive.
Increase default container report interval to 60 mins .
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5382
How was this patch tested?
only a config change