-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bindings/python): add ruff as linter #4135
Conversation
Since ruff is in pyproject.toml, I guess not `pip install` here is ok
now it break the ci, which means works :)
I guess we could ignore these first. |
Thanks for your effort! Now our ruff check is running. Lint like the following could be ignored: python/opendal/__init__.py:18:1: F403 `from ._opendal import *` used; unable to detect undefined names
python/opendal/__init__.py:20:11: F405 `_opendal` may be undefined, or defined from star imports
python/opendal/__init__.py:21:11: F405 `_opendal` may be undefined, or defined from star imports
And the error like
Could be fixed easily. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
there are some more lint rules
could be done in further pr, leave a note here. |
try fix #3468