NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable #9382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattyb149
reviewed
Oct 21, 2024
| public static final PropertyDescriptor TRANSLATION_STRATEGY = new PropertyDescriptor.Builder() | ||
| .required(true) | ||
| .name("Column Name Translation Strategy") | ||
| .description("The strategy used to normalize table column name") |
There was a problem hiding this comment.
Do all the non-regex options uppercase the name for translation purposes? If so that's fine but somewhere (maybe here) the doc should reflect that no matter the strategy (unless possibly the new Regex one), the name will be uppercased to do case-insensitive matching
There was a problem hiding this comment.
Hi @mattyb149
I have updated the documentation
…e uppercased to do case-insensitive matching irrespective of strategy
mattyb149
reviewed
Nov 1, 2024
| "Spaces will be removed from column names Ex. 'User Name' becomes 'USERNAME'"), | ||
| REMOVE_UNDERSCORE_AND_SPACE("Remove Underscores and Spaces", | ||
| "Spaces and Underscores will be removed from column names Ex. 'User_1 Name' becomes 'USER1NAME'"), | ||
| REMOVE_ALL_SPECIAL_CHAR("Remove Regular Expression Characters", |
There was a problem hiding this comment.
Can you include examples for the two Regex choices? They are the most complex so the more and clearer the documentation the better. After that I'm good to merge!
There was a problem hiding this comment.
hi @mattyb149
I have added example . please have a look
…e uppercased to do case-insensitive matching irrespective of strategy
…8-clean # Conflicts: # nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/db/TranslationStrategy.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
old PR link : #7544 , #8995
Summary
NIFI-11858
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation