NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable #8995

ravinarayansingh · 2024-06-22T20:03:39Z

old PR link : NIFI-11858

Summary

NIFI-11858

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Apache NiFi Jira issue created

Pull Request Tracking

Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

Pull Request based on current revision of the main branch
Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

Build completed using mvn clean install -P contrib-check
- JDK 21

Licensing

New dependencies are compatible with the Apache License 2.0 according to the License Policy
New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

Documentation formatting appears as expected in rendered files

…eDatabaseTable

...ard-processors/src/main/java/org/apache/nifi/processors/standard/db/TranslationStrategy.java

…eDatabaseTable

# Conflicts: # nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java # nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateDatabaseTable.java

mattyb149 · 2024-08-29T17:27:36Z

There are merge conflicts here, I recommend not merging main into your feature branch but rather pulling down the latest main then checking out your feature branch and rebasing.

…eDatabaseTable

# Conflicts: # nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java # nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/PutDatabaseRecordTest.java

ravinarayansingh · 2024-08-30T02:22:15Z

There are merge conflicts here, I recommend not merging main into your feature branch but rather pulling down the latest main then checking out your feature branch and rebasing.

@mattyb149 I have resolved the conflict and rebased .

ravinarayansingh · 2024-09-06T15:47:24Z

hi @mattyb149
let me know if any thing need to be done form my side

mattyb149 · 2024-09-16T13:13:42Z

I apologize for losing track of this, but now there are merge conflicts. Once the conflicts are resolved I will finish the review and hopefully it is ready for merging.

…eDatabaseTable

ravinarayansingh · 2024-09-20T15:50:48Z

I apologize for losing track of this, but now there are merge conflicts. Once the conflicts are resolved I will finish the review and hopefully it is ready for merging.

Hi @mattyb149
I have resolved the conflict please have a look

…changes (apache#9316) - Drained request InputStream - Added try-with-resources for response OutputStream Signed-off-by: David Handermann <[email protected]>

- Ensure NARs are loaded in parent-first order during restart - Allow replacing a NAR when other NARs are dependent on it - Improvements to catch Throwable in several places to handle NoClassDefFoundError Signed-off-by: David Handermann <[email protected]>

…pache#9292) - Transform input FlowFile instead of cloned FlowFile Signed-off-by: David Handermann <[email protected]>

…e#9318) Signed-off-by: David Handermann <[email protected]>

* NIFI-13721: Migrating additional details to markdown. * NIFI-13721: Rebuilding documentation to generate mark up on the client. * NIFI-13721: Removing old documentation approach. * NIFI-13721: Rebase main and final fixing button colors. * NIFI-13721: Fixing rat issues. * NIFI-13721: Removing generated comonent documentation. - Removing links and images from additional details markdown. * NIFI-13721: Recreating package lock following rebase. * NIFI-13721: Updating documentation for M3. * NIFI-13721: Fixing broken test. * NIFI-13721: Addressing review feedback. * NIFI-13721: Addressing review feedback. * NIFI-13721: Ensuring the selected item is visible after routing. * NIFI-13721: Fixing reportingTaskTypes in finding extensions for a given type. * NIFI-13721: Updating the see also component to handle when the referenced extension is not installed. * NIFI-13721: Fixing expansion panel header styles.

This closes apache#9315

This closes apache#9319. Signed-off-by: Peter Turcsanyi <[email protected]>

- Only synchronize flow with the coordinator after getting cluster response This closes apache#9317 Signed-off-by: David Handermann <[email protected]>

…r context This closes apache#9324 Signed-off-by: Joseph Witt <[email protected]>

…with parent SSL Context Service. Parent SSL Context Service is added to root process group instead of managament controller services Signed-off-by: Ferenc Erdei <[email protected]> This closes apache#9268.

…alculation Signed-off-by: Ferenc Kis <[email protected]> This closes apache#9320.

… exception when it fails to convert a value. This closes apache#9327 Signed-off-by: Mike Thomsen <[email protected]>

ravinarayansingh · 2024-10-01T16:23:16Z

I apologize for losing track of this, but now there are merge conflicts. Once the conflicts are resolved I will finish the review and hopefully it is ready for merging.

Hi @mattyb149 I have resolved the conflict please have a look

Hi @mattyb149
I have rebased

mattyb149 · 2024-10-01T16:36:23Z

Having 64 commits is usually the sign of a merge or rebase that didn't go smoothly. In general you'd have your own feature branch based on main, and when the PR says there are merge conflicts you'd checkout main instead, pull the latest, then check your feature branch out and rebase against main. That will allow your PR to have an up-to-date branch with only the changes you made on top of the latest main.

ravinarayansingh · 2024-10-01T16:58:36Z

Having 64 commits is usually the sign of a merge or rebase that didn't go smoothly. In general you'd have your own feature branch based on main, and when the PR says there are merge conflicts you'd checkout main instead, pull the latest, then check your feature branch out and rebase against main. That will allow your PR to have an up-to-date branch with only the changes you made on top of the latest main.

Hi @mattyb149
following are the commands i have executed

git checkout main
git pull origin main
git checkout NIFI-11858-new
git rebase main

…eDatabaseTable

# Conflicts: # nifi-extension-bundles/nifi-airtable-bundle/nifi-airtable-processors/src/main/resources/docs/org.apache.nifi.processors.airtable.QueryAirtableTable/additionalDetails.md # nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/documentation/ui/common/additional-details/additional-details.component.html # nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/service/canvas-utils.service.ts # nifi-frontend/src/main/frontend/apps/nifi/src/styles.scss # nifi-frontend/src/main/frontend/libs/shared/src/assets/styles/_app.scss # nifi-frontend/src/main/frontend/libs/shared/src/assets/styles/_codemirror-theme.scss # nifi-frontend/src/main/frontend/package-lock.json # nifi-frontend/src/main/frontend/package.json

…nifi

# Conflicts: # nifi-frontend/src/main/frontend/libs/shared/src/assets/styles/_app.scss # nifi-frontend/src/main/frontend/package-lock.json

mattyb149 · 2024-10-11T20:54:00Z

Unfortunately this PR is not in good shape to merge. Do you have a list of the commits you added as part of this PR vs the merge commits or any other change you didn't initiate? I can help put up a more viable PR with only your commits against the latest Apache NiFi main branch.

ravinarayansingh · 2024-10-12T01:11:10Z

hi @mattyb149
i have create new PR #9382
please have a look we can close this

exceptionfactory · 2024-10-12T16:25:51Z

Closing in favor of updated PR #9382.

Configurable Column Name Normalization in PutDatabaseRecord and Updat…

ba73d42

…eDatabaseTable

ChrisSamo632 changed the title ~~NIFI-11858 new PR for Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable~~ NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable Jun 23, 2024

mattyb149 reviewed Jun 25, 2024

View reviewed changes

...ard-processors/src/main/java/org/apache/nifi/processors/standard/db/TranslationStrategy.java Outdated Show resolved Hide resolved

added REMOVE_UNDERSCORE_AND_SPACE strategy

ec9a9b4

ravinarayansingh requested a review from mattyb149 July 1, 2024 17:26

ravinarayansingh added 7 commits July 1, 2024 23:21

added REMOVE_UNDERSCORE_AND_SPACE strategy

a8f45f0

Configurable Column Name Normalization in PutDatabaseRecord and Updat…

dce9dca

…eDatabaseTable

added REMOVE_UNDERSCORE_AND_SPACE strategy

3031136

added REMOVE_UNDERSCORE_AND_SPACE strategy

82d0700

fix styles

348b472

Merge branch 'main' into NIFI-11858-new

f6455f7

ravinarayansingh added 6 commits August 29, 2024 13:35

Merge branch 'main' of https://github.com/ravinarayansingh/nifi

c907d0d

Configurable Column Name Normalization in PutDatabaseRecord and Updat…

9615771

…eDatabaseTable

added REMOVE_UNDERSCORE_AND_SPACE strategy

1ed6cb3

added REMOVE_UNDERSCORE_AND_SPACE strategy

674dd97

fixed conflict

ea38ea6

ravinarayansingh added 7 commits September 19, 2024 14:00

Merge branch 'main' of https://github.com/ravinarayansingh/nifi

921583c

Merge branch 'main' of https://github.com/ravinarayansingh/nifi

6ecf313

Configurable Column Name Normalization in PutDatabaseRecord and Updat…

15a0344

…eDatabaseTable

added REMOVE_UNDERSCORE_AND_SPACE strategy

0ccb67c

added REMOVE_UNDERSCORE_AND_SPACE strategy

d24addc

fixed conflict

0f6eaa2

Merge remote-tracking branch 'origin/NIFI-11858-new' into NIFI-11858-new

8f89f09

markap14 and others added 12 commits October 1, 2024 09:22

NIFI-13807 Fixed Stream Handling in Runtime Management Server HTTP Ex…

6d1e926

…changes (apache#9316) - Drained request InputStream - Added try-with-resources for response OutputStream Signed-off-by: David Handermann <[email protected]>

NIFI-13779 Improved Provenance Lineage for Python FlowFileTransform (a…

9293724

…pache#9292) - Transform input FlowFile instead of cloned FlowFile Signed-off-by: David Handermann <[email protected]>

NIFI-13809 Upgraded Maven Archetype Plugin from 3.2.1 to 3.3.0 (apach…

e7d0677

…e#9318) Signed-off-by: David Handermann <[email protected]>

[NIFI-13806] finalize color hues (apache#9315)

4b40863

This closes apache#9315

NIFI-13810 Handled Trailing Separator for Paths in URI Builder

05f4c1a

This closes apache#9319. Signed-off-by: Peter Turcsanyi <[email protected]>

NIFI-13803 Improved Clustered Flow Loading and Synchronization Process

e48d2ca

- Only synchronize flow with the coordinator after getting cluster response This closes apache#9317 Signed-off-by: David Handermann <[email protected]>

NIFI-13817 Protect against null asset ids when synchronizing paramete…

a8af617

…r context This closes apache#9324 Signed-off-by: Joseph Witt <[email protected]>

NIFI-13746 [MiNiFi] Override controller services SSL Context Service …

66cb2cc

…with parent SSL Context Service. Parent SSL Context Service is added to root process group instead of managament controller services Signed-off-by: Ferenc Erdei <[email protected]> This closes apache#9268.

NIFI-13812 [MiNiFi][C2] Add component type into Agent Manifest Hash c…

270bb96

…alculation Signed-off-by: Ferenc Kis <[email protected]> This closes apache#9320.

NIFI-13819 Provided a row number and sheet name if ExcelReader throws…

e29eddc

… exception when it fails to convert a value. This closes apache#9327 Signed-off-by: Mike Thomsen <[email protected]>

ravinarayansingh added 8 commits October 3, 2024 18:41

Merge branch 'main' of https://github.com/ravinarayansingh/nifi

6cb9028

Configurable Column Name Normalization in PutDatabaseRecord and Updat…

dd24a04

…eDatabaseTable

added REMOVE_UNDERSCORE_AND_SPACE strategy

b51ec1b

added REMOVE_UNDERSCORE_AND_SPACE strategy

eacf0c0

fixed conflict

bdcd7ce

Merge branch 'NIFI-11858-new' of https://github.com/ravinarayansingh/…

7abde6b

…nifi

Merge branch 'main' of https://github.com/ravinarayansingh/nifi

97ed499

# Conflicts: # nifi-frontend/src/main/frontend/libs/shared/src/assets/styles/_app.scss # nifi-frontend/src/main/frontend/package-lock.json

ravinarayansingh added a commit to ravinarayansingh/nifi that referenced this pull request Oct 12, 2024

cleaned and required changes for apache#8995

1a28559

ravinarayansingh mentioned this pull request Oct 12, 2024

NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable #9382

Open

10 tasks

exceptionfactory closed this Oct 12, 2024

ravinarayansingh added a commit to ravinarayansingh/nifi that referenced this pull request Nov 18, 2024

cleaned and required changes for apache#8995

57bb76b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable #8995

NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable #8995

ravinarayansingh commented Jun 22, 2024

mattyb149 commented Aug 29, 2024

ravinarayansingh commented Aug 30, 2024

ravinarayansingh commented Sep 6, 2024

mattyb149 commented Sep 16, 2024

ravinarayansingh commented Sep 20, 2024

ravinarayansingh commented Oct 1, 2024

mattyb149 commented Oct 1, 2024

ravinarayansingh commented Oct 1, 2024

mattyb149 commented Oct 11, 2024

ravinarayansingh commented Oct 12, 2024

exceptionfactory commented Oct 12, 2024

NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable #8995

NIFI-11858 Configurable Column Name Normalization in PutDatabaseRecord and UpdateDatabaseTable #8995

Conversation

ravinarayansingh commented Jun 22, 2024

Summary

Tracking

Issue Tracking

Pull Request Tracking

Pull Request Formatting

Verification

Build

Licensing

Documentation

mattyb149 commented Aug 29, 2024

ravinarayansingh commented Aug 30, 2024

ravinarayansingh commented Sep 6, 2024

mattyb149 commented Sep 16, 2024

ravinarayansingh commented Sep 20, 2024

ravinarayansingh commented Oct 1, 2024

mattyb149 commented Oct 1, 2024

ravinarayansingh commented Oct 1, 2024

mattyb149 commented Oct 11, 2024

ravinarayansingh commented Oct 12, 2024

exceptionfactory commented Oct 12, 2024